Fix bug #308 #309
Fix bug #308 #309
Conversation
|
|
||
| _TEMP_DIR: Optional[tempfile.TemporaryDirectory] = None | ||
| TEMP_DIR_NAME = Optional[None] | ||
|
|
||
| TEMP_DIR_NAME: Optional[None | str | PosixPath] = None |
There was a problem hiding this comment.
Optional[Union[str,PosixPath]]. sorry still at 3.8 :-)
| @@ -114,7 +114,8 @@ def redefine_temp_location(path: str) -> str: | |||
| _clear() | |||
|
|
|||
| # cleanup old temporary directory | |||
| shutil.rmtree(TEMP_DIR_NAME, ignore_errors=True) | |||
| if TEMP_DIR_NAME is not None: | |||
There was a problem hiding this comment.
interestingly, in python 3.9, the unit tests don't fail here
apparently the ignore_errors kicks in here
shutil.py:721
try:
orig_st = os.lstat(path)
except Exception:
onerror(os.lstat, path, sys.exc_info())
return
could you run this unit test with 3.12?
There was a problem hiding this comment.
indeed, 3.11 works fine but in 3.12 I get the same error as you do
change log in docs don't reflect that change in behaviour https://docs.python.org/3/library/shutil.html#shutil.rmtree
should we file an issue to python?
| @@ -114,7 +114,8 @@ def redefine_temp_location(path: str) -> str: | |||
| _clear() | |||
|
|
|||
| # cleanup old temporary directory | |||
| shutil.rmtree(TEMP_DIR_NAME, ignore_errors=True) | |||
| if TEMP_DIR_NAME is not None: | |||
| shutil.rmtree(TEMP_DIR_NAME, ignore_errors=True) | |||
There was a problem hiding this comment.
do we need the rmtree at all? doesn't tempdir take care of this?
There was a problem hiding this comment.
if you decide to keep it please add a comment that in python 3.12 , ignore_errors does not work if None is passed
fixes #308