Added logic to support both string and symbol access to keys in dialog hash under options #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ad3c892 to
b550694
Compare
|
Checked commit gtanzillo@b550694 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
jrafanie
approved these changes
Apr 4, 2019
There was a problem hiding this comment.
Looks good to me. The only possible downside is that HWIA #keys method or #each will walk the keys with the key name as a string and that is different than what we had prior to this PR.
It feels like this is the safest change we can make and is isolated to dialogs.
tinaafitz
approved these changes
Apr 4, 2019
lfu
approved these changes
Apr 4, 2019
abellotti
approved these changes
Apr 4, 2019
simaishi
pushed a commit
that referenced
this pull request
Apr 4, 2019
Added logic to support both string and symbol access to keys in dialog hash under options (cherry picked from commit 023da5f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1696362
|
Hammer backport details: |
simaishi
pushed a commit
that referenced
this pull request
Apr 4, 2019
Added logic to support both string and symbol access to keys in dialog hash under options (cherry picked from commit 023da5f) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1696363
|
Gaprindashvili backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue that was introduced in #312. That change resulted in symbolizing the keys in the
dialoghash underoptionswhen a service is ordered with an API request.This change enables accessing keys in the dialog hash both as strings and symbols
/cc @tinaafitz, @lfu, @jrafanie
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1694716