Deep symbolize keys when parsing options

[jntullo]

When parsing the options for creating / updating a request, only :symbolize_keys is being called. However, all of the keys must be symbolized via :deep_symbolize_keys

Related: ManageIQ/manageiq#16891
Fixes #260

BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1618517

cc: @lfu @evertmulder

[abellotti]

LGTM!! should we add a test here ?

[miq-bot]

Checked commit jntullo@b5f152a with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
2 files checked, 0 offenses detected
Everything looks fine. 🍰

[lfu]

Can API save the data in the same format as what UI does? Currently the data saved via UI is like this.

---
:src_ids:
- '7000000000029'
:vm_memory: 1024
:disk_add:
- !ruby/hash:ActiveSupport::HashWithIndifferentAccess
  disk_size_in_mb: '1'
  persistent: true
  thin_provisioned: true
  new_controller_type: VirtualLsiLogicController
  dependent: true
  bootable: false
:request_type: :vm_reconfigure

[jntullo]

@lfu we could possibly convert to yaml...however, at the moment it is not playing nice:

TypeError: no implicit conversion of Symbol into Integer
from /Users/jilliantullo/code/manageiq/app/models/mixins/miq_request_mixin.rb:4:in `[]'

After looking at it, it appears that the create_request method we are calling is expecting a hash.

[lfu]

@jntullo options is a serialized column. So DB saves the options data in yaml format. I was hoping to keep the data format in DB the same as what UI does. Hash would work if the format can't be exactly the same. Currently all the callers use the options key as a symbol.

[abellotti]

Thanks @jntullo for fixing this 👍

[Fryguy]

@simaishi This is marked fine/yes, but @imtayadeway has opened ManageIQ/manageiq#17300 for backport.

[simaishi]

@imtayadeway Is there a BZ associated with this PR?

[Fryguy]

@imtayadeway closed ManageIQ/manageiq#17300 because I think you can just backport even though it's a split repo. If you need/want it reopened, feel free.

[agrare]

https://bugzilla.redhat.com/show_bug.cgi?id=1618517

[agrare]

@miq-bot remove-label bugzilla needed

[simaishi]

Fine backport details:

$ git log -1
commit d2e16459393bdd1db0b4533a42c39bf12f6f88dd
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Tue Feb 13 10:13:40 2018 -0500

    Merge pull request #312 from jntullo/deep_symbolize_request
    
    Deep symbolize keys when parsing options
    (cherry picked from commit 4e7edaad50c50b266858ec071f0cc60ad127feec)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1623574

[simaishi]

Gaprindashvili backport details:

$ git log -1
commit 89e79662805a7c7c8c0cd28c51a124e5448e0111
Author: Alberto Bellotti <abellotti@users.noreply.github.com>
Date:   Tue Feb 13 10:13:40 2018 -0500

    Merge pull request #312 from jntullo/deep_symbolize_request
    
    Deep symbolize keys when parsing options
    (cherry picked from commit 4e7edaad50c50b266858ec071f0cc60ad127feec)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1623573