Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anaconda upload #17

Merged
merged 3 commits into from
Feb 19, 2020
Merged

Anaconda upload #17

merged 3 commits into from
Feb 19, 2020

Conversation

ogrisel
Copy link
Contributor

@ogrisel ogrisel commented Feb 17, 2020

Use the shared staging area as openblas builds are useful for several projects.

I am not sure if the encrypted value for the token in the appveyor configuration will work. Maybe it will need to be re-encrypted by someone logged in with the MacPython github account on appveyor. It's very clear to me.

Potential fix for #14.

@ogrisel
Copy link
Contributor Author

ogrisel commented Feb 17, 2020

When I run this with my account I could upload successfully everything to the staging area:

https://anaconda.org/multibuild-wheels-staging/openblas/files

@ogrisel
Copy link
Contributor Author

ogrisel commented Feb 17, 2020

I just noticed that I used -p openblas instead of -p openblas-libs to the package name. Let me know if you prefer the latter.

@mattip
Copy link
Collaborator

mattip commented Feb 17, 2020

Please change to openblas-libs which might make it infinitesimally more likely that someone searching for the source of the library will end up here. Even better would be if we could create a subdirectory https://anaconda.org/multibuild-wheels-staging/MacPython/openblas-libs/files, and then all the recipes under MacPython could use that staging area, making it easier for ananconda.org to manage these as a group

@mattip
Copy link
Collaborator

mattip commented Feb 17, 2020

Wow, when I go to the download link, I get reprimanded from Firefox that there are multiple trackers on that site, what's up with that?

@mattip
Copy link
Collaborator

mattip commented Feb 17, 2020

Even better would be if we could create a subdirectory

That would probably break many things, like making the pypi-compatible index

@ogrisel
Copy link
Contributor Author

ogrisel commented Feb 17, 2020

Please change to openblas-libs which might make it infinitesimally more likely that someone searching for the source of the library will end up here.

Done.

That would probably break many things, like making the pypi-compatible index.

For the openblas-libs binary archives, the CI consumer will use wget or curl, not pypi so there is no real point in making it pypi compatible.

For wheels on the other hand, anaconda exposes the pip compatible index URL as pypi.org would:

https://pypi.anaconda.org/scipy-wheels-nightly/simple/

Wow, when I go to the download link, I get reprimanded from Firefox that there are multiple trackers on that site, what's up with that?

Indeed but at the same time we would not point end users to go to that page. Most downloads would happen via continuous integration bots.

@ogrisel
Copy link
Contributor Author

ogrisel commented Feb 17, 2020

The travis build failed because the secret upload token is not defined in pull requests. Do you want me to change the code to skip the upload step if the secret variable is missing?

The appveyor build failed because the MINGW_URL download failed or was invalid. This is weird, it never failed earlier when I test on my fork.

@tylerjereddy
Copy link
Collaborator

Note that our version numbers on binaries are still confusing: #4. So if the uploads seem to work but with strange v0... that looks a bit old, it is probably ok.

@ogrisel
Copy link
Contributor Author

ogrisel commented Feb 17, 2020

Yes right now the version number is grabbed by $(cd OpenBLAS && git describe --tags).

@ogrisel
Copy link
Contributor Author

ogrisel commented Feb 17, 2020

The skipping message works as expected on appveyor.

Copy link
Collaborator

@tylerjereddy tylerjereddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this & see what gets uploaded where & what goes wrong.

The changes look sensible & CI is all green. At least this affects enough projects that a few people will probably notice what needs to be fixed up soon-ish if we miss something.

I imagine just checking the upload location once the merged CI runs will be fairly informative.

@tylerjereddy tylerjereddy merged commit 8a70c46 into MacPython:master Feb 19, 2020
@ogrisel ogrisel deleted the anaconda-upload branch February 19, 2020 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants