-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Anaconda upload #17
Anaconda upload #17
Conversation
When I run this with my account I could upload successfully everything to the staging area: https://anaconda.org/multibuild-wheels-staging/openblas/files |
I just noticed that I used |
Please change to openblas-libs which might make it infinitesimally more likely that someone searching for the source of the library will end up here. Even better would be if we could create a subdirectory https://anaconda.org/multibuild-wheels-staging/MacPython/openblas-libs/files, and then all the recipes under MacPython could use that staging area, making it easier for ananconda.org to manage these as a group |
Wow, when I go to the download link, I get reprimanded from Firefox that there are multiple trackers on that site, what's up with that? |
That would probably break many things, like making the pypi-compatible index |
Done.
For the openblas-libs binary archives, the CI consumer will use wget or curl, not pypi so there is no real point in making it pypi compatible. For wheels on the other hand, anaconda exposes the pip compatible index URL as pypi.org would: https://pypi.anaconda.org/scipy-wheels-nightly/simple/
Indeed but at the same time we would not point end users to go to that page. Most downloads would happen via continuous integration bots. |
The travis build failed because the secret upload token is not defined in pull requests. Do you want me to change the code to skip the upload step if the secret variable is missing? The appveyor build failed because the |
Note that our version numbers on binaries are still confusing: #4. So if the uploads seem to work but with strange |
Yes right now the version number is grabbed by |
The skipping message works as expected on appveyor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this & see what gets uploaded where & what goes wrong.
The changes look sensible & CI is all green. At least this affects enough projects that a few people will probably notice what needs to be fixed up soon-ish if we miss something.
I imagine just checking the upload location once the merged CI runs will be fairly informative.
Use the shared staging area as openblas builds are useful for several projects.
I am not sure if the encrypted value for the token in the appveyor configuration will work. Maybe it will need to be re-encrypted by someone logged in with the MacPython github account on appveyor. It's very clear to me.
Potential fix for #14.