Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenBLAS version number in binaries #4

Closed
tylerjereddy opened this issue May 9, 2019 · 3 comments
Closed

OpenBLAS version number in binaries #4

tylerjereddy opened this issue May 9, 2019 · 3 comments

Comments

@tylerjereddy
Copy link
Collaborator

tylerjereddy commented May 9, 2019

The binaries that are generated from this repo can, in some cases, have OpenBLAS version numbers that are not a reflection of what has actually been built.

Usually in these cases the correct commit hash on the OpenBLAS development branch will be included in the file name despite the incorrect OpenBLAS version specification.

This probably shouldn't happen--especially since we now have programmatic access to a version string directly from openblas get_config(). It causes confusion for reviewers & communication with OpenBLAS team.

@tylerjereddy
Copy link
Collaborator Author

This only applies to the file names themselves--we can always know for sure with the usual ctypes calls through get_config(). Still, it can cause confusion.

@mattip
Copy link
Collaborator

mattip commented Feb 5, 2024

This will be closed when we move entirely to the wheels

@mattip
Copy link
Collaborator

mattip commented Jul 22, 2024

We have moved to wheels. Closing.

@mattip mattip closed this as completed Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants