Update ISOMIP+ test case visualization and instructions #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestingI have tested the new viz on a 2-year Ocean0 run on both my laptop and Grizzly. I have worked through the instructions myself but will wait until @cbegeman had also done so before merging, in case there are errors or sources of confusion. |
Also add pixel decoding for Mac compatibility
mark-petersen
approved these changes
Jun 12, 2019
There was a problem hiding this comment.
Since this is all visualization of ISOMIP+, I'll let you and @cbegeman test it to your satisfaction. Let me know when it is ready, and I'll find a time to merge it in that fits with E3SM PRs.
|
@xylar how do you render markdown files? I tried to use a few chrome extensions and didn't get them to work. |
|
Thanks @mark-petersen. My instructions are a bit of a work in progress because of #274. I think the viz is ready to merge (though it could get some future updates, of course). I view Markdown files on GitHub itself: I also edit them on GitHub. |
|
Great! The instructions are very nice. There are a few extra back-quote characters (`) on that page you just linked to. |
|
Thanks, fixed. |
|
@xylar I'll merge this later this week, as E3SM repo will likely be open next week. You said it's "ready to merge". Did you mean to take off the "Don't merge" tag? |
|
As I said, my instructions are waiting on #274 to be merged. Right now, they refer to a fix that doesn't work and would not be needed with that merge. So this is not ready to merge until that update happens, unless I make a separate PR for the instructions. |
|
Thanks @xylar . I have this one and a few python LIGHT scripts. My plan is to have one E3SM PR for that bunch, followed by the one E3SM PR with just the BGC version update (in case of problems). Could you change these instructions as if the BGC version update is already committed? I'll merge one immediately after the other, but that ordering is easier for me. |
|
@mark-petersen, I have done so. |
mark-petersen
added a commit
that referenced
this pull request
Jun 14, 2019
This merge updates the ISOMIP+ viz to make it a python 3 package. It also adds detailed instructions for how to setup and run the test case on LANL IC. I added ffmpeg as a new package to be included in the COMPASS conda environment. ISOMIP+ viz uses this to make movies.
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jun 20, 2019
Update mpas-source, COMPASS testing only This PR does not change any E3SM model code. Only changes python scripts for internal ocean testing: * Add new ISOMIP+ viz package and test case improvements (MPAS-Dev/MPAS-Model#275) * LIGHT test case IC/analysis improvements (MPAS-Dev/MPAS-Model#260) [BFB]
jonbob
added a commit
to E3SM-Project/E3SM
that referenced
this pull request
Jun 21, 2019
Update mpas-source, COMPASS testing only This PR does not change any E3SM model code. Only changes python scripts for internal ocean testing: * Add new ISOMIP+ viz package and test case improvements (MPAS-Dev/MPAS-Model#275) * LIGHT test case IC/analysis improvements (MPAS-Dev/MPAS-Model#260) [BFB]
mark-petersen
added a commit
that referenced
this pull request
Jul 2, 2019
…/develop This merge adds time-varying land-ice forcing via the following fields: landIceDraft landIcePressure landIceFraction A test case isomip_plus/2km/time_varying_Ocean0 is added as a (relatively trivial) test of this forcing. In this test case, landIcePressure and landIceDraft are initially 10% of their "correct" values and increase linearly over 1 year to their full values, then remain constant for an additional year. However, the test case crashes sometime during the second year because layers become too thin and/or tilted, or velocities become too large. This is an intentional feature of the test case, showing why further work is needed to handle coupled ice dynamics. Modifications are made to the ISOMIP+ viz (#275) to correctly handle repeated running of the viz while the simulation is in progress. A few other tweaks (e.g. the format of dates in the figure titles) are also included. Modifications were made to how sea-level is maintained in ISOMIP+ test cases despite freshwater fluxes and changes in land-ice pressure. A fictitious evaporation was already used at the northern boundary, but this has been modified to adjust to sea-level itself rather than melt fluxes to accommodate changing land-ice pressure. Finally, a division-by-zero error in timeSeriesStatsGlobal was fixed. If melt fluxes are turned on but there are no locations where the melt mask nonzero (which happened in my testing), global stats was trying to compute mean fluxes and other stats with zero area in the denominator. This has been fixed.
ashwathsv
pushed a commit
to ashwathsv/MPAS-Model
that referenced
this pull request
Jul 21, 2020
…/develop This merge updates the ISOMIP+ viz to make it a python 3 package. It also adds detailed instructions for how to setup and run the test case on LANL IC. I added ffmpeg as a new package to be included in the COMPASS conda environment. ISOMIP+ viz uses this to make movies.
ashwathsv
pushed a commit
to ashwathsv/MPAS-Model
that referenced
this pull request
Jul 21, 2020
…to ocean/develop This merge adds time-varying land-ice forcing via the following fields: landIceDraft landIcePressure landIceFraction A test case isomip_plus/2km/time_varying_Ocean0 is added as a (relatively trivial) test of this forcing. In this test case, landIcePressure and landIceDraft are initially 10% of their "correct" values and increase linearly over 1 year to their full values, then remain constant for an additional year. However, the test case crashes sometime during the second year because layers become too thin and/or tilted, or velocities become too large. This is an intentional feature of the test case, showing why further work is needed to handle coupled ice dynamics. Modifications are made to the ISOMIP+ viz (MPAS-Dev#275) to correctly handle repeated running of the viz while the simulation is in progress. A few other tweaks (e.g. the format of dates in the figure titles) are also included. Modifications were made to how sea-level is maintained in ISOMIP+ test cases despite freshwater fluxes and changes in land-ice pressure. A fictitious evaporation was already used at the northern boundary, but this has been modified to adjust to sea-level itself rather than melt fluxes to accommodate changing land-ice pressure. Finally, a division-by-zero error in timeSeriesStatsGlobal was fixed. If melt fluxes are turned on but there are no locations where the melt mask nonzero (which happened in my testing), global stats was trying to compute mean fluxes and other stats with zero area in the denominator. This has been fixed.
mark-petersen
added a commit
to mark-petersen/MPAS-Model
that referenced
this pull request
Jan 11, 2021
…to ocean/develop This merge adds time-varying land-ice forcing via the following fields: landIceDraft landIcePressure landIceFraction A test case isomip_plus/2km/time_varying_Ocean0 is added as a (relatively trivial) test of this forcing. In this test case, landIcePressure and landIceDraft are initially 10% of their "correct" values and increase linearly over 1 year to their full values, then remain constant for an additional year. However, the test case crashes sometime during the second year because layers become too thin and/or tilted, or velocities become too large. This is an intentional feature of the test case, showing why further work is needed to handle coupled ice dynamics. Modifications are made to the ISOMIP+ viz (MPAS-Dev#275) to correctly handle repeated running of the viz while the simulation is in progress. A few other tweaks (e.g. the format of dates in the figure titles) are also included. Modifications were made to how sea-level is maintained in ISOMIP+ test cases despite freshwater fluxes and changes in land-ice pressure. A fictitious evaporation was already used at the northern boundary, but this has been modified to adjust to sea-level itself rather than melt fluxes to accommodate changing land-ice pressure. Finally, a division-by-zero error in timeSeriesStatsGlobal was fixed. If melt fluxes are turned on but there are no locations where the melt mask nonzero (which happened in my testing), global stats was trying to compute mean fluxes and other stats with zero area in the denominator. This has been fixed.
caozd999
pushed a commit
to caozd999/MPAS-Model
that referenced
this pull request
Jan 14, 2021
…/develop This merge updates the ISOMIP+ viz to make it a python 3 package. It also adds detailed instructions for how to setup and run the test case on LANL IC. I added ffmpeg as a new package to be included in the COMPASS conda environment. ISOMIP+ viz uses this to make movies.
caozd999
pushed a commit
to caozd999/MPAS-Model
that referenced
this pull request
Jan 14, 2021
…to ocean/develop This merge adds time-varying land-ice forcing via the following fields: landIceDraft landIcePressure landIceFraction A test case isomip_plus/2km/time_varying_Ocean0 is added as a (relatively trivial) test of this forcing. In this test case, landIcePressure and landIceDraft are initially 10% of their "correct" values and increase linearly over 1 year to their full values, then remain constant for an additional year. However, the test case crashes sometime during the second year because layers become too thin and/or tilted, or velocities become too large. This is an intentional feature of the test case, showing why further work is needed to handle coupled ice dynamics. Modifications are made to the ISOMIP+ viz (MPAS-Dev#275) to correctly handle repeated running of the viz while the simulation is in progress. A few other tweaks (e.g. the format of dates in the figure titles) are also included. Modifications were made to how sea-level is maintained in ISOMIP+ test cases despite freshwater fluxes and changes in land-ice pressure. A fictitious evaporation was already used at the northern boundary, but this has been modified to adjust to sea-level itself rather than melt fluxes to accommodate changing land-ice pressure. Finally, a division-by-zero error in timeSeriesStatsGlobal was fixed. If melt fluxes are turned on but there are no locations where the melt mask nonzero (which happened in my testing), global stats was trying to compute mean fluxes and other stats with zero area in the denominator. This has been fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge updates the ISOMIP+ viz to make it a python 3 package. It also adds detailed instructions for how to setup and run the test case on LANL IC.
I added ffmpeg as a new package to be included in the COMPASS conda environment. ISOMIP+ viz uses this to make movies.