Update BGC version #274
Update BGC version #274
Conversation
The only change is the addition of python 3 support during the build.
TestingI have made sure the code builds on Grizzly with ifort. I haven't done any run tests yet. @mark-petersen, when you're back maybe you can help with that. @maltrud, let me know what tests you might recommend to make sure BGC remains unchanged. |
|
@xylar i'm not sure why the BGC_TAG has changed? it should be 2b8aadd. |
|
@maltrud, that was the whole point of the pull requests I just merged to E3SM/Ocean-BGC This makes ocean/develop update to include those commits. Happy for another solution to the python 3 incompatibility if you have one... |
|
@xylar sorry i'm apparently more confused than usual. you made some python changes to makedep.py, right? those are fine i assume. but there's also a change to get_BGC.sh which has nothing to do with python--the tag for the BGC module has been changed which it shouldn't. |
|
@maltrud, the tag in get_BGC points to a commit in E3SM-Project/Ocean-BGC. It used to point to the latest commit in that repo (2b8aadd). But now I just committed fixes to Maybe this link will help: |
|
@xylar ok i get it. i thought i was the only one who could make changes to E3SM-Project/Ocean-BGC. all is good. no wonder i couldn't find the tag in my local BGC repo--should've gone to github.... |
There was a problem hiding this comment.
Compiled on IC with gnu and intel. That was with a fresh directory, so it had to obtain new BGC commit. Passed nightly test suite, but none of those include a BGC test.
@maltrud, could you run a 5-day BGC test with this in E3SM? I don't foresee any problems since it is only a python 2 to 3 upgrade. It would be easiest for me to merge this into MPAS, then give you an E3SM branch to test.
|
@mark-petersen sure i'll do a test if you make an e3sm branch. |
The only change is the addition of python 3 support during the build. Brings in E3SM-Project/Ocean-BGC#1 and E3SM-Project/Ocean-BGC#2.
…3006) Update mpas-source to current ocean-BGC submodule This PR updates the ocean-BGC submodule to python 3 compliance (MPAS-Dev/MPAS-Model#274). [BFB]
…elop The only change is the addition of python 3 support during the build. Brings in E3SM-Project/Ocean-BGC#1 and E3SM-Project/Ocean-BGC#2.
The only change is the addition of python 3 support during the build.
Brings in E3SM-Project/Ocean-BGC#1 and E3SM-Project/Ocean-BGC#2.