Salvage cmip5-ng #90
Merged
Salvage cmip5-ng #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time encoding in cmip5-ng is apparently not compatible with the default approach used by xarray 0.17.0 to read in data. Hence, the use_cftime argument needed to be introduced.
In case no *r1i1* run exists leave the runs in their original order. Only reason *r1i1* is moved to front is to make it possible to compute anomalies by baselining every run with respect to the first run (i.e., a legacy from the original MESMER description paper approach of training on a single run).
r14 of rcp45 of EC-EARTH has a faulty time axis in the cmip5-ng archive with 10 years always sharing the same time stamp. Bug is reported which will likely eventually lead to other changes (i.e., this exclusion will become irrelevant again because either the run will be removed from the archive or it will be fixed).
|
Looks ok to me. The changes should not cause a problem for #55 I think - we don't touch the same functions. Tests would be nice but testing IO is one of the more difficult things to do so I'd leave it as is. |
mathause
approved these changes
Aug 25, 2021
|
Great, thanks! I removed the test item from the task list now (considering the effort that would be needed to test this in the current code setup). & just for future reference: In a later PR, we should replace the part of the code that moves the r1i1 run to the first position (if r1i1 exists) with the cleaner sorting solution proposed by you in issue #91. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort . && black . && flake8CHANGELOG.rstFixes issues with reading in data from cmip5-ng archive for all RCPs
use_cftime=Trueto deal with incompatible calendar for default xarray approach (-> thanks to @mathause for suggesting this solution!)