-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor load_cmipng_tas and load_cmipng_hfds #55
Conversation
I might still want to add tests here (after #52) |
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
==========================================
+ Coverage 77.53% 78.34% +0.81%
==========================================
Files 26 26
Lines 1322 1293 -29
==========================================
- Hits 1025 1013 -12
+ Misses 297 280 -17
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This would be ready for review. More refactoring could be done but let's do this in another PR. |
This adds a common function for
load_cmipng_tas
andload_cmipng_hfds
as suggested by your comment. The only difference was the use ofnp.average
with a masked vs not-masked array. As tas has data everywhere this should not make a difference.Next up are then tests and then an internal refactor.