refactor lowess smoothing #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #193 +/- ##
=======================================
Coverage ? 79.81%
=======================================
Files ? 33
Lines ? 1442
Branches ? 0
=======================================
Hits ? 1151
Misses ? 291
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
znicholls
reviewed
Sep 6, 2022
| @@ -26,6 +26,9 @@ New Features | |||
| - Extract function to select the order of the auto regressive model: ``mesmer.core.auto_regression._select_ar_order_xr`` | |||
| (`#176 <https://github.com/MESMER-group/mesmer/pull/176>`_). | |||
| By `Mathias Hauser <https://github.com/mathause>`_. | |||
| - Refactor the LOWESS smooting for xarray objects: :py:func:`mesmer.core.smooting.lowess`. | |||
| @@ -25,6 +25,7 @@ Statistical core functions | |||
| ~core.auto_regression._select_ar_order_xr | |||
| ~core.auto_regression._fit_auto_regression_xr | |||
| ~core.auto_regression._draw_auto_regression_correlated_np | |||
| ~core.smooting.lowess | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
train_gt_ic_LOWESS#146 & split out statistical functions #149isort . && black . && flake8CHANGELOG.rstSpitting out the lowess smoothing. This is much nicer and cleaner again.