Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply extract method to train_gt_ic_LOWESS #146

Closed
Tracked by #149
znicholls opened this issue Jun 3, 2022 · 1 comment
Closed
Tracked by #149

Apply extract method to train_gt_ic_LOWESS #146

znicholls opened this issue Jun 3, 2022 · 1 comment

Comments

@znicholls
Copy link
Collaborator

The function train_gt_ic_LOWESS is too long (see code smells e.g. https://refactoring.guru/smells/long-method)

To fix that, we need to split it into multiple, smaller methods which are self describing (a technique known as extract method, see https://refactoring.guru/extract-method). In the process, it will also be possible to remove most of (if not all the) comments (see code smell https://refactoring.guru/smells/comments).

@mathause
Copy link
Member

I'd argue that this has been done in #193

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants