Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove py2 things from core #2756

Merged
merged 2 commits into from
Jun 15, 2020
Merged

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jun 14, 2020

Towards #2541

Changes made in this Pull Request:

  • Removes py2 things from core

PR Checklist

  • Tests?
  • Docs? N/A
  • CHANGELOG updated? N/A
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Jun 14, 2020

Codecov Report

Merging #2756 into develop will decrease coverage by 0.00%.
The diff coverage is 79.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2756      +/-   ##
===========================================
- Coverage    91.17%   91.17%   -0.01%     
===========================================
  Files          176      176              
  Lines        23798    23806       +8     
  Branches      3134     3134              
===========================================
+ Hits         21699    21705       +6     
- Misses        1476     1480       +4     
+ Partials       623      621       -2     
Impacted Files Coverage Δ
package/MDAnalysis/core/__init__.py 100.00% <ø> (ø)
package/MDAnalysis/core/topology.py 100.00% <ø> (ø)
package/MDAnalysis/core/topologyattrs.py 95.29% <33.33%> (-0.12%) ⬇️
package/MDAnalysis/core/groups.py 97.80% <68.75%> (-0.35%) ⬇️
package/MDAnalysis/core/_get_readers.py 96.05% <77.77%> (+0.05%) ⬆️
package/MDAnalysis/core/selection.py 99.48% <100.00%> (+<0.01%) ⬆️
package/MDAnalysis/core/topologyobjects.py 97.50% <100.00%> (-0.01%) ⬇️
package/MDAnalysis/core/universe.py 95.86% <100.00%> (-0.02%) ⬇️
core/__init__.py 100.00% <0.00%> (ø)
package/MDAnalysis/lib/transformations.py 78.62% <0.00%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085ac0f...06dee88. Read the comment docs.

@orbeckst orbeckst added the remove-2.0 deprecated in 1.0 and to be removed in 2.0 label Jun 15, 2020
@richardjgowers richardjgowers merged commit 74c2c15 into MDAnalysis:develop Jun 15, 2020
@IAlibay IAlibay deleted the rm-py2-core branch June 15, 2020 10:36
PicoCentauri pushed a commit to PicoCentauri/mdanalysis that referenced this pull request Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-Core maintainability remove-2.0 deprecated in 1.0 and to be removed in 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants