Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Python 2 constructs #2541

Closed
orbeckst opened this issue Feb 19, 2020 · 8 comments · Fixed by #2753 or #2778
Closed

remove Python 2 constructs #2541

orbeckst opened this issue Feb 19, 2020 · 8 comments · Fixed by #2753 or #2778
Milestone

Comments

@orbeckst
Copy link
Member

orbeckst commented Feb 19, 2020

Release 2.0 does not support Python 2 anymore (see the Roadmap) so we should get rid of compatibility code (six and friends).

EDIT: In this issue we also decided to drop Python 3.5 support from 2.0.

@orbeckst orbeckst added this to the 2.0 milestone Feb 19, 2020
@RMeli
Copy link
Member

RMeli commented Feb 19, 2020

Which versions of Python 3 will be supported? (Asking mainly for f-strings, PEP 498)

@orbeckst
Copy link
Member Author

orbeckst commented Feb 19, 2020 via email

@richardjgowers
Copy link
Member

I think we usually followed whatever numpy was also doing, which I think was what continuous integration and conda-forge supported. I think we usually have to be quite slow because we need to support that one cluster that still happens to run 2.7 in 2020.

@IAlibay
Copy link
Member

IAlibay commented Feb 20, 2020

I don't know when 1.19 comes out, but numpy seems to have dropped support for 3.5 on its development branch: https://github.com/numpy/numpy/blob/master/INSTALL.rst.txt#prerequisites

My understanding is that major releases of numpy are scheduled ~ 6 months, which means 1.19 should come in late June. So that might align itself quite well with a late Q2 goal for MDA 2.0.

@tylerjereddy
Copy link
Member

tylerjereddy commented Feb 21, 2020

SciPy will also be 3.6+ only for the next release (1.5.x). NumPy & SciPy have started to remove large amounts of Python 2 compatibility constructs in their master branches now that their Python 2.7 LTS branches have had what should be their final updates/need for backports.

@orbeckst
Copy link
Member Author

For 2.0 I don't have a problem starting with Python >= 3.6.

@IAlibay
Copy link
Member

IAlibay commented Jun 11, 2020

Going to link #2739 (comment) back to here.

My current approach has been to remove six / future things every time I deal with a file. We probably want a means of tracking progress though.

@IAlibay
Copy link
Member

IAlibay commented Jun 13, 2020

As mentioned in #2750 (comment) it might be that we want to chip away at this in stages. Having discussed this with @lilyminium, it might be an idea to break it down per "section" where we cover what is both in package & testsuite:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants