Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compile error regarding <memory> header #143

Open
jfrascon opened this issue Nov 10, 2022 · 0 comments
Open

fix: compile error regarding <memory> header #143

jfrascon opened this issue Nov 10, 2022 · 0 comments

Comments

@jfrascon
Copy link

jfrascon commented Nov 10, 2022

Hello, there is the issue #163 in Livox-SDK repo asking for a fix in the file 'sdk_core/src/base/thread_base.h'
You already have a pull request that solves the issue, and it is really simple, just adding the "memory" header file to the previous file.
In the repo livox_ros_driver there is the same problem. It does not compile with newer versions of gcc and clang.
Reason: Livox-SDK/Livox-SDK#163 (comment)
In this repo, the fix is just addind the "memory" header into the file https://github.com/Livox-SDK/livox_ros_driver/blob/master/livox_ros_driver/timesync/timesync.h.

Please, can you include that header in this file, so we can add the this repo as a submodule of our projects instead for convenience.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant