Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some GenerativeDistribution missing setParam #478

Closed
walterxie opened this issue May 22, 2024 · 0 comments
Closed

some GenerativeDistribution missing setParam #478

walterxie opened this issue May 22, 2024 · 0 comments
Labels
bug Something isn't working
Milestone
1.6

Comments

@walterxie
Copy link
Collaborator

walterxie commented May 22, 2024 •
edited
Loading

some GenerativeDistribution classes seem missing setParam(), such as SubsampledTree, Beta.

Two ways :

  1. overwrite setParam(String paramName, Value<?> value);
  2. implement setter for every parameters.

Prefer the 1st.
@walterxie walterxie added the bug Something isn't working label May 22, 2024
@walterxie walterxie mentioned this issue May 22, 2024
Closed
walterxie added a commit that referenced this issue May 22, 2024
@walterxie
add setParam #468 #478
aebb8f2
EvaLiyt added a commit that referenced this issue May 22, 2024
@EvaLiyt
add setParam to SampleBranch.java #478
f000ab2
walterxie added a commit that referenced this issue May 22, 2024
@walterxie
fix the bug to change constants but not setInput #468 #478
0ecfdf8
@walterxie walterxie added this to the 1.6 milestone May 22, 2024
walterxie added a commit that referenced this issue May 23, 2024
@walterxie
document the class #468 #478
9e822a9
walterxie added a commit that referenced this issue May 23, 2024
@walterxie
document the class #468 #478
4af1e72
walterxie added a commit that referenced this issue May 23, 2024
@walterxie
add missing setParam or setters #478
3450eb3
walterxie added a commit that referenced this issue May 23, 2024
@walterxie
replace setters with setParam for all Number, otherwise type mismatch…
d09a7ff 
… err #478
walterxie added a commit that referenced this issue May 23, 2024
@walterxie
optional arg should have if condition in setParam #478
6fc85c8
walterxie added a commit that referenced this issue May 23, 2024
@walterxie
add if to optional arg in Sample #478
f400a6c
walterxie added a commit that referenced this issue May 23, 2024
@walterxie
doc #478
c1ab0ea
walterxie added a commit that referenced this issue Aug 7, 2024
@walterxie
replace setters with setParam for all Number, otherwise type mismatch…
c068967 
… err #478
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.6
Development

No branches or pull requests
1 participant
@walterxie