Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weekly Patch Release v1.3.6 [full merge, no squash] #7986

Merged
merged 10 commits into from
Jun 17, 2021
Merged

Weekly Patch Release v1.3.6 [full merge, no squash] #7986

merged 10 commits into from
Jun 17, 2021

Conversation

carmocca
Copy link
Contributor

What does this PR do?

See #7467

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • [n/a] Did you make sure your PR does only one thing, instead of bundling different changes together?
  • [n/a] Did you make sure to update the documentation with your changes? (if necessary)
  • [n/a] Did you write any new necessary tests? (not for typos and docs)
  • [n/a] Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

carmocca and others added 7 commits June 15, 2021 14:12
@carmocca
Update CHANGELOG
2060cc1
@kaushikb11 @carmocca
Fix logs overwriting issue for remote fs (#7889)
d5c8c62 
* Fix logs overwriting issue for remote fs

* Add test
@Queuecumber @carmocca
Remove rank_zero_only on DataModule prepare_data (#7945)
d502153 
Signed-off-by: Max Ehrlich <max.ehr@gmail.com>
@awaelchli @carmocca
fix myst-parser warning blocking docs ci (#7967)
9940ff2
@senarvi @carmocca
Seed all workers when using DDP (#7942)
a0c31be 
* Seed all workers when using DDP

* Fix to dataloader seeding

* Make argument name explicit

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>

* Use f-strings when logging

* Removed a redundant log message

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@Borda @carmocca
remove parsing comments (#7958)
0d48daf 
* remove parsing comments
* \s

Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
@speediedan @carmocca
@kaushikb11 @awaelchli
Properly handle parent modules w/ parameters in BaseFinetuning call…
ab32020 
…back (#7931)

Co-authored-by: Daniel Dale <dan@distributedinsight.com>
Co-authored-by: Carlos Mocholí <carlossmocholi@gmail.com>
Co-authored-by: Kaushik B <45285388+kaushikb11@users.noreply.github.com>
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@carmocca carmocca added this to the v1.3.x milestone Jun 15, 2021
@carmocca carmocca self-assigned this Jun 15, 2021
@carmocca carmocca mentioned this pull request Jun 15, 2021
Closed
@codecov
Copy link

codecov bot commented Jun 15, 2021 •
edited
Loading

Codecov Report

Merging #7986 (47dfa6c) into release/1.3.x (c292788) will decrease coverage by 0%.
The diff coverage is 93%.

❗ Current head 47dfa6c differs from pull request most recent head 468c31a. Consider uploading reports for the commit 468c31a to get more accurate results

@@              Coverage Diff              @@
##           release/1.3.x   #7986   +/-   ##
=============================================
- Coverage             92%     92%   -0%     
=============================================
  Files                200     200           
  Lines              13040   13043    +3     
=============================================
- Hits               11982   11947   -35     
- Misses              1058    1096   +38

@carmocca carmocca mentioned this pull request Jun 15, 2021
Merged
8 tasks
Borda
Borda reviewed Jun 15, 2021
View reviewed changes
Copy link
Member

@Borda Borda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

version ++

@lexierule lexierule merged commit 808534f into release/1.3.x Jun 17, 2021
@lexierule lexierule deleted the prepare-v1.3.6 branch June 17, 2021 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Borda Borda Borda left review comments

@justusschock justusschock justusschock approved these changes

@SeanNaren SeanNaren SeanNaren approved these changes

@awaelchli awaelchli awaelchli approved these changes

@ananthsub ananthsub Awaiting requested review from ananthsub

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@tchaton tchaton Awaiting requested review from tchaton

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

Assignees

@carmocca carmocca

Labels
None yet
Projects
None yet
Milestone
pl:1.3.x
Development

Successfully merging this pull request may close these issues.
10 participants
@carmocca @awaelchli @Borda @SeanNaren @justusschock @lexierule @kaushikb11 @Queuecumber @senarvi @speediedan