-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix myst-parser warning blocking docs ci #7967
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #7967 +/- ##
======================================
- Coverage 91% 91% -0%
======================================
Files 203 203
Lines 13129 13129
======================================
- Hits 11992 11979 -13
- Misses 1137 1150 +13 |
awaelchli
requested review from
Borda,
carmocca,
justusschock,
kaushikb11,
SeanNaren,
tchaton and
williamFalcon
as code owners
June 14, 2021 10:12
kaushikb11
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:hand_with_index_and_middle_fingers_crossed:
Borda
approved these changes
Jun 14, 2021
Borda
added
3rd party
Related to a 3rd-party
docs
Documentation related
priority: 1
Medium priority task
ready
PRs ready to be merged
labels
Jun 14, 2021
edgarriba
approved these changes
Jun 14, 2021
docker failing with |
for more information, see https://pre-commit.ci
SeanNaren
approved these changes
Jun 14, 2021
lexierule
pushed a commit
that referenced
this pull request
Jun 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3rd party
Related to a 3rd-party
ci
Continuous Integration
docs
Documentation related
priority: 1
Medium priority task
ready
PRs ready to be merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The CI on master is failing with the docs make job in CI failing with the warning
This PR unblocks master from merging PRs.
Issue opened on myst-parser: executablebooks/MyST-Parser#394
Before submitting
PR review
Anyone in the community is free to review the PR once the tests have passed.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:
Did you have fun?
Make sure you had fun coding 🙃