Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename TensorboardLogger -> TensorBoardLogger #611

Closed
wants to merge 1 commit into from
Closed

Rename TensorboardLogger -> TensorBoardLogger #611

wants to merge 1 commit into from

Conversation

awaelchli
Copy link
Contributor

@awaelchli awaelchli commented Dec 8, 2019

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos, doc improvements)
  • Did you read the contributor guideline?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?

What does this PR do?

Follow up to #607. Renames TensorboardLogger to TensorBoardLogger.
I used PyCharm to rename all occurrences.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

@awaelchli
Copy link
Contributor Author

It may be in conflict with #609 and #610. Maybe merge them first, then I can update this PR.

@Borda
Copy link
Member

Borda commented Dec 8, 2019

already implemented here - #610

@awaelchli
Copy link
Contributor Author

@Borda hmm. in a commit called "fix add_hparams". I did not see that ...

@awaelchli awaelchli closed this Dec 8, 2019
@awaelchli awaelchli deleted the tb-logger-rename branch December 9, 2019 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants