Fix logger, tensorboard #610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neggert
reviewed
Dec 8, 2019
Comment on lines
67
to
73
| try: | ||
| # in case converting from namespace, todo: rather test if it is namespace | ||
| params = vars(params) | ||
| except TypeError: | ||
| pass | ||
| if params is not None: | ||
| self.experiment.add_hparams(hparam_dict=dict(params)) |
There was a problem hiding this comment.
What problem is this fixing? The current implementation is consistent with all the other loggers.
There was a problem hiding this comment.
a dictionary cannot be converted via vars
There was a problem hiding this comment.
Just for future reference, do we pass a dict anywhere? I thought we always passed some form of Namespace.
|
Thanks for the bug fixes. I think maybe I did a rebase right at the end and forgot to re-run the tests. I promise they were all passing at some point. |
|
well, not only, also |
4 tasks
|
Yeah, missing the |
|
It is fixed, but more serious is missing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #607 to be able to do #609
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.