#1061 When converting HTML to PDF, background color is not applied #1075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pull request if for the 1.3-java8 branch because right now we need to use Java 8. But eventually, the same fix should go to the main branch. |
|
asturio
pushed a commit
that referenced
this pull request
Feb 23, 2024
asturio
pushed a commit
that referenced
this pull request
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the new Feature/Bugfix
Added support for background color specified in the CCS "style" attribute.
I have made a few changes in
FactoryProperties- I've added support for "background" and "background-color" and simplified the code for "color" (this change is also covered by a test).I've renamed the test
FontSizeTesttoStylesTestand refactored it to eliminate code duplicity. The source HTML is now stored in resources as files, which is easier to extend it and also makes it possible to view it in a browser and then compare it with generated PDF.Related Issue: #1061
Unit-Tests for the new Feature/Bugfix
Compatibilities Issues
None
Testing details
Run the
StylesTest.testBackgroundColor. See also the generated 'Background Color.pdf'