Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update imports in harvest.api #129

Merged
merged 1 commit into from
Apr 3, 2022
Merged

update imports in harvest.api #129

merged 1 commit into from
Apr 3, 2022

Conversation

victorphoenix3
Copy link
Contributor

fixes: #68

Signed-off-by: Jayati Shrivastava gaurijove@gmail.com

@tristanlatr
Copy link
Collaborator

Thanks for your contribution!
Please note that util PR #114 is merged, all new pull requests should target the develop branch.
I'll let you change the target branch, since this kind of changes will likely create conflicts.
Sorry about that.

@victorphoenix3 victorphoenix3 changed the base branch from master to develop March 26, 2022 18:06
@victorphoenix3 victorphoenix3 force-pushed the cleanup/imports branch 2 times, most recently from e6f2942 to 0ecc00e Compare March 26, 2022 18:25
@victorphoenix3
Copy link
Contributor Author

@tristanlatr Hi, I rebased my changes onto the top of develop and have changed the base of the PR.

@tristanlatr
Copy link
Collaborator

Thanks, if I read the diff correctly, there were no more start imports actually.

@tristanlatr
Copy link
Collaborator

Hi @victorphoenix3,

I think your patch is adding unused imports. I think this is due to the rebasing.

Could you fix it?

Thanks

@victorphoenix3 victorphoenix3 changed the title remove star imports remove unused imports Mar 29, 2022
@victorphoenix3
Copy link
Contributor Author

@tristanlatr looks like the star imports are only present in the master branch, and not in the develop branch. I have removed all the unused imports from harvest/api.py.

@tristanlatr tristanlatr changed the base branch from develop to master March 30, 2022 20:38
2ynn
2ynn reviewed Apr 2, 2022
View reviewed changes
saskatoon/harvest/api.py Outdated Show resolved Hide resolved
@victorphoenix3 victorphoenix3 force-pushed the cleanup/imports branch 2 times, most recently from a8e1ef4 to 83212cf Compare April 3, 2022 12:17
@victorphoenix3
update imports from harvest.api
bcbbc07 
Signed-off-by: Jayati Shrivastava <gaurijove@gmail.com>
@victorphoenix3 victorphoenix3 changed the title remove unused imports update imports in harvest.api Apr 3, 2022
@2ynn
Copy link
Collaborator

2ynn commented Apr 3, 2022

@victorphoenix3 thanks for rebasing and sorry for the confusion about branches

@2ynn 2ynn changed the base branch from master to develop April 3, 2022 13:34
@2ynn 2ynn merged commit a20f127 into LesFruitsDefendus:develop Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2ynn 2ynn 2ynn approved these changes

@tristanlatr tristanlatr Awaiting requested review from tristanlatr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removing and avoiding the start imports
3 participants
@victorphoenix3 @tristanlatr @2ynn