Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forms - list views - filters - user roles - and more #114

Merged
merged 189 commits into from
Mar 30, 2022
Merged

Forms - list views - filters - user roles - and more #114

merged 189 commits into from
Mar 30, 2022

Conversation

2ynn
Copy link
Collaborator

@2ynn 2ynn commented Sep 20, 2021 •
edited by tristanlatr
Loading

I pushed the develop branch to https://saskatoon-dev.lesfruitsdefendus.org

I would appreciate if you could test it, especially all the different forms:

  • new owner based on pending_property (see the "register" button next to "contact" title in a pending property detail page)
  • new person (pickleader, core-member, volunteer, etc..)
  • new (organization + contact person)
  • new (property + owner)

I the meantime I will work on a document to list all the new features to test so the core members can try it too.

2ynn and others added 30 commits June 10, 2021 18:02
@2ynn
fixed redirect url in PublicPropertyForm
63d8bcd
@2ynn
Fix #102 ValidationError now passed to template
de0cd3a
@2ynn
fix #93: tags missing in harvest link
f8d7f79
@2ynn
member migrations dependencies are needed for initial fixtures
7ce1f08
@2ynn
added core group to auth.user admin
908d4d9
@2ynn
removed todo, clarified serialization for person name
5eb8d4d
@2ynn
added person link + auth.user link for core members
4548f72
@2ynn
issue #104 added core auth.group + core member fixtures
caf024a
@2ynn
added Core Member role in community list view
ffb43d3
@2ynn
volunteer picker is now an accepted picker
ced17e9
@2ynn
added pending property fixture
66c1067
@2ynn
added nice owner in auth.user fixture
eedf0ea
@2ynn
Fix #105 added pending contact information to property details
097e663
@2ynn
added Person form and prefilled owner registration
c3021cb
@2ynn
added person update form + owner edit link
3086f73
@2ynn
moved pending notification on property title
f4156f7
@2ynn
Issue #104 restrict access to edit property page
8b926b0
@2ynn
issue #104 restrict access to person create/update
5311819
@2ynn
cleanup harvest api imports
017b068
@2ynn
changed person update link + permissions
714cf0f
@2ynn
being more specific with permissions and auth groups
487c401
@2ynn
Issue #74 add username to header
3044b6a
@2ynn
added cancel button on person create/update form
d6b6394
@2ynn
cleanup imports
a7b8f53
@2ynn
Merge pull request #108 from LesFruitsDefendus/owner-form
6551f8b 
Register new owner based on pending property contact info
@2ynn
moved property forms to generic templates + added cancel urls
7798e51
@2ynn
added cancel button to person update form
285fcf1
@2ynn
_#110 moved equipment create/update views to generic template
fe696fa
@2ynn
Issue #110 moved harvest create/update views to generic template
69fcf5a
@2ynn
Issue #104 moved comment create view to generic template
2c7f154
This was referenced Mar 26, 2022
Merged
Merged
@2ynn 2ynn marked this pull request as ready for review March 26, 2022 16:31
@tristanlatr tristanlatr mentioned this pull request Mar 27, 2022
Closed
@tristanlatr tristanlatr mentioned this pull request Mar 29, 2022
Closed
@2ynn
Copy link
Collaborator Author

2ynn commented Mar 29, 2022

@tristanlatr is it okay if I still push to develop directly until we merge this PR?

@tristanlatr
Copy link
Collaborator

Yes please go ahead. But let’s merge this PR I the coming days :)

@tristanlatr tristanlatr mentioned this pull request Mar 30, 2022
Closed
tristanlatr
tristanlatr approved these changes Mar 30, 2022
View reviewed changes
Copy link
Collaborator

@tristanlatr tristanlatr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it!

Special thanks to @2ynn for all the the volunteer work!

@tristanlatr tristanlatr merged commit 03e8ed3 into master Mar 30, 2022
@mina-atef-00
Copy link
Collaborator

Do we continue submitting PRs to the develop branch or should we switch to master?

@tristanlatr
Copy link
Collaborator

You can target master now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tristanlatr tristanlatr tristanlatr approved these changes

@tiagovaz tiagovaz Awaiting requested review from tiagovaz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2ynn @tristanlatr @mina-atef-00 @farhanmasud