Polyline fixes #657
Closed
Polyline fixes #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
December 12, 2016 00:13
This was referenced Dec 14, 2016
z0d14c
commented
Dec 16, 2016
| .on('mousemove', this._onMouseMove, this) // Necessary to prevent 0.8 stutter | ||
| .on('mousedown', this._onMouseDown, this) | ||
| .on('mouseup', this._onMouseUp, this) // Necessary for 0.8 compatibility |
There was a problem hiding this comment.
these got shuffled around as i was experimenting with fixes, settled on no change here. i was trying to conditionally bind these listeners based on L.Browser.touch, but that is unreliable because, for example, windows touchscreen devices may need to support both types of events.
6 tasks
|
Any progress with this? |
|
This has been merged with #661 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After much adieu, I have a PR that I've tested on Chrome/iOS/Android/IE and appears to solve the following issues reliably:
description of code changes
these changes result in a much more cross-platform stable version of leaflet-draw, and so I hope that despite the lack of tests, it can be merged, as I may not get a chance to write tests anytime soon. i tried to tag in all of the issues i believe that it probably fixes.