Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polygon and line not working with leaflet 1.0.0+ #667

Open
6 tasks done
jignesh-techvasu opened this issue Dec 27, 2016 · 9 comments
Open
6 tasks done

polygon and line not working with leaflet 1.0.0+ #667

jignesh-techvasu opened this issue Dec 27, 2016 · 9 comments

Comments

@jignesh-techvasu
Copy link

jignesh-techvasu commented Dec 27, 2016

  • I'm reporting a bug, not asking for help
  • I've looked at the documentation to make sure the behaviour is documented and expected
  • I'm sure this is a Leaflet Draw code issue, not an issue with my own code nor with the framework I'm using (Cordova, Ionic, Angular, React…)
  • I've searched through the issues to make sure it's not yet reported

How to reproduce

  • Leaflet version I'm using: 1.0.1
  • Leaflet Draw version I'm using: 0.4.2
  • Browser (with version) I'm using: Chrome 55
  • OS/Platform (with version) I'm using: Windows
  • None of my code. Just open current leaflet live demo page : https://leaflet.github.io/Leaflet.draw/docs/examples/full.html
  • Click on line icon to draw line.
  • Add 2-3 points and try to click on last point to complete the drawing
  • You will notice drawing doesn't get finished
  • Try to draw polygon same way now
  • You wont be able to finish polygon by clicking on first point.

What behaviour I'm expecting and which behaviour I'm seeing

User should be able to finish polyline by clicking on last point. Same way, user should be able to finish polygon by clicking on first point.

Minimal example reproducing the issue

  • this example is as simple as possible
  • this example does not rely on any third party code

No need for anything else as issue is reproducible on leafdraw demo page itself.

@mike-unearth
Copy link

This will be fixed with this pull request: #657

@jignesh-techvasu
Copy link
Author

@mike-unearth : That's great!.. Thank you.

@jignesh-techvasu
Copy link
Author

@mike-unearth : Any idea about merge schedule for this pull? I am actually counting on it :)

@mike-unearth
Copy link

It was merged today actually! Try version 0.4.8.

@jignesh-techvasu
Copy link
Author

@mike-unearth : Great!... Thank you.

@chiccorusso
Copy link

chiccorusso commented Jan 3, 2017

Hi. I'm having the same problem. The update to 0.4.8 solved the missed clic on the last point, but the problem persists when I try to finish a polyline (or a polygon) using the "Finish" button.
In that case a last point is added to the polyline, and then the the "Finish" button is clicked.

antea_palladio_web_-_sewer

The same thing happens with the "Delete last point" button: a new point is added, and is immediately deleted.

@vladimirbuskin
Copy link
Contributor

@chiccorusso hello, that pull request #658
should make it work

@ddproxy
Copy link
Member

ddproxy commented Jan 4, 2017

@chiccorusso PR's have been merged to resolve this issue.

@chiccorusso
Copy link

Thank-you! It's working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants