feat: rewards v2 #153
Merged
feat: rewards v2 #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9bb2ab to
b953d06
Compare
2cc8b92 to
4e95448
Compare
294a3cc to
a0c05b8
Compare
# Motivation As part of the Rewards v2 SigmaPrime audit, we need to tackle the following issues: 1. ELSC2-04: Inconsistent Number Formatting In Merkle Tree Values 2. ELSC2-10: Use Of Deprecated Package `xerrors` 3. ELSC2-12: Miscellaneous General Comments (Unused Field `description`) # Modifications * Renamed `pkg/rewards/operatorAvsRegistrationSnaphots.go` to `pkg/rewards/operatorAvsRegistrationSnapshots.go` * Renamed `pkg/rewards/operatorAvsRegistrationSnaphots_test.go` to `pkg/rewards/operatorAvsRegistrationSnapshots_test.go` * Removed use of `xerrors` package. * Updated `%d` usages to `%016x`. * Adding `description` field to `OperatorDirectedRewardSubmission` model. # Result Rewards v2 SigmaPrime audit fixes.
# Motivation As part of the Rewards v2 SigmaPrime audit, we need to tackle the following issues: 1. ELSC2-04: Inconsistent Number Formatting In Merkle Tree Values Specifically for the multiplier and amount fields in the Operator Directed Rewards Submission Model. # Modifications * Handling as `%064x` and `%024x` instead of strings. # Result `ELSC2-04` SigmaPrime audit fix.
# Motivation We need to support the default split dynamically in the Rewards calculation since it can be set by governance. Currently it is hardcoded to 10%.
set block height for fork
Rewards v2 audit reports
set version to v2.0.0-rc.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.