feat: dynamic default split #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9472987 to
affc5fb
Compare
seanmcgary
requested changes
Jan 8, 2025
62254f3 to
0300a41
Compare
0xrajath
commented
Jan 8, 2025
seanmcgary
approved these changes
Jan 8, 2025
ypatil12
approved these changes
Jan 8, 2025
seanmcgary
pushed a commit
that referenced
this pull request
Jan 8, 2025
# Motivation We need to support the default split dynamically in the Rewards calculation since it can be set by governance. Currently it is hardcoded to 10%.
seanmcgary
pushed a commit
that referenced
this pull request
Jan 14, 2025
# Motivation We need to support the default split dynamically in the Rewards calculation since it can be set by governance. Currently it is hardcoded to 10%.
seanmcgary
pushed a commit
that referenced
this pull request
Jan 14, 2025
# Motivation We need to support the default split dynamically in the Rewards calculation since it can be set by governance. Currently it is hardcoded to 10%.
seanmcgary
pushed a commit
that referenced
this pull request
Jan 16, 2025
# Motivation We need to support the default split dynamically in the Rewards calculation since it can be set by governance. Currently it is hardcoded to 10%.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We need to support the default split dynamically in the Rewards calculation since it can be set by governance. Currently it is hardcoded to 10%.
Tests