Skip to content
This repository has been archived by the owner on May 22, 2023. It is now read-only.

Rename in-project jasmine dependency (jasmine2) #6

Closed
x1B opened this issue Jul 15, 2015 · 2 comments
Closed

Rename in-project jasmine dependency (jasmine2) #6

x1B opened this issue Jul 15, 2015 · 2 comments
Assignees
@x1B
Labels
breaking

Comments

@x1B
Copy link
Member

x1B commented Jul 15, 2015

The installed jasmine 2.x should get a new folder name so that widgets in a single project may be tested with either jasmine 1.x or jasmine 2.x
@x1B x1B self-assigned this Jul 15, 2015
@x1B x1B changed the title Rename in-project jasmine 2 Rename in-project jasmine dependency (jasmine2) Jul 15, 2015
@x1B
Copy link
Member Author

x1B commented Jul 15, 2015

For this to work, we need LaxarJS/karma-laxar#4

x1B added a commit that referenced this issue Jul 16, 2015
@x1B
(#6) use laxarSpec meta to find runSpec and jasmine
e343c6b
x1B added a commit that referenced this issue Jul 16, 2015
@x1B
Merge branch 'feature/6-rename-jasmine-folder-rebase'
b961c9a 
* feature/6-rename-jasmine-folder-rebase:
  (#6) use laxarSpec meta to find runSpec and jasmine
@x1B
Copy link
Member Author

x1B commented Jul 16, 2015

Implemented on master (v0.3.0).

Breaking Change

To be able to test both

  • widgets that are using Jasmine v1.3 (using laxar/laxar_testing) and
  • widgets that are using Jasmine v2.3 (using laxar-testing)

this library now needs the following to work:

  • jasmine v2.3.x must be be configured under the RequireJS path jasmine2
  • the spec-runner.html and spec-runner.js must correspond to the examples. In particular, the jasmineMajorVersion and the testRunner must be specified.

For more information, have a look at the manual on jasmine compatibility.

@x1B x1B closed this as completed Jul 16, 2015
@x1B x1B removed the in progress label Jul 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@x1B x1B

Labels
breaking
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@x1B