chore(callback): split get_callback_list to two functions to avoid unnecessary table creation #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
previously approved these changes
May 21, 2024
f523f11 to
4afe7c1
Compare
The merge-base changed after approval.
1391ec2 to
b6e6e6e
Compare
outsinre
reviewed
May 21, 2024
outsinre
approved these changes
May 21, 2024
chronolaw
approved these changes
May 21, 2024
…necessary table creation
b6e6e6e to
ed766ea
Compare
bungle
added a commit
to bungle/lua-resty-events
that referenced
this pull request
May 28, 2024
### Summary - fix(tests): fix tests to not be order dependent on multi-worker scenario (Kong#46) - chore(callback): remove unnecessary assert when the type is already checked (Kong#50) - chore(queue): rename DEFAULT_QUEUE_LEN to more meaningful MAX_QUEUE_PREALLOCATE (Kong#52) - chore(callback): split get_callback_list to two functions to avoid unnecessary table creation (Kong#51) - fix(worker): do not premature kill threads when not exiting (Kong#47) - fix(broker): do not premature kill threads when not exiting (Kong#48) - fix(worker): separate communication and event processing to different timers (Kong#53) - caused by Kong#47
Merged
bungle
added a commit
to bungle/lua-resty-events
that referenced
this pull request
May 28, 2024
### Summary - fix(tests): fix tests to not be order dependent on multi-worker scenario (Kong#46) - chore(callback): remove unnecessary assert when the type is already checked (Kong#50) - chore(queue): rename DEFAULT_QUEUE_LEN to more meaningful MAX_QUEUE_PREALLOCATE (Kong#52) - chore(callback): split get_callback_list to two functions to avoid unnecessary table creation (Kong#51) - fix(worker): do not premature kill threads when not exiting (Kong#47) - fix(broker): do not premature kill threads when not exiting (Kong#48) - fix(worker): separate communication and event processing to different timers (Kong#53) - caused by Kong#47
bungle
added a commit
to bungle/lua-resty-events
that referenced
this pull request
May 28, 2024
### Summary - fix(tests): fix tests to not be order dependent on multi-worker scenario (Kong#46) - chore(callback): remove unnecessary assert when the type is already checked (Kong#50) - chore(queue): rename DEFAULT_QUEUE_LEN to more meaningful MAX_QUEUE_PREALLOCATE (Kong#52) - chore(callback): split get_callback_list to two functions to avoid unnecessary table creation (Kong#51) - fix(worker): do not premature kill threads when not exiting (Kong#47) - fix(broker): do not premature kill threads when not exiting (Kong#48) - fix(worker): separate communication and event processing to different timers (Kong#53) - caused by Kong#47
bungle
added a commit
that referenced
this pull request
May 28, 2024
### Summary - fix(tests): fix tests to not be order dependent on multi-worker scenario (#46) - chore(callback): remove unnecessary assert when the type is already checked (#50) - chore(queue): rename DEFAULT_QUEUE_LEN to more meaningful MAX_QUEUE_PREALLOCATE (#52) - chore(callback): split get_callback_list to two functions to avoid unnecessary table creation (#51) - fix(worker): do not premature kill threads when not exiting (#47) - fix(broker): do not premature kill threads when not exiting (#48) - fix(worker): separate communication and event processing to different timers (#53) - caused by #47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.