fix(worker): do not premature kill threads when not exiting #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a741d3 to
56dc199
Compare
56dc199 to
1a03dd9
Compare
outsinre
reviewed
May 21, 2024
outsinre
reviewed
May 21, 2024
1a03dd9 to
12d74f6
Compare
outsinre
previously approved these changes
May 22, 2024
|
@bungle @chronolaw can we merge this now? |
e37554c to
5fb3f1d
Compare
chronolaw
reviewed
May 27, 2024
9d7e392 to
681cac7
Compare
outsinre
reviewed
May 27, 2024
| ngx.shared.dict:set("broker-pid", ngx.worker.pid()) | ||
| end | ||
|
|
||
| if id == 0 or id == 1 then |
There was a problem hiding this comment.
How about the id == 2? The broker itself also receive the event.
There was a problem hiding this comment.
@outsinre, broker runs on id=2, see (and in this test I am not interested in broker as that is what is about to crash and hard to make it with current design reliable):
https://github.com/Kong/lua-resty-events/pull/47/files#diff-f8f62b1b0529d11f96be1a1f25b7f11df85ce86fb864528bd0d623f14bf22278R23
There was a problem hiding this comment.
Yes, worker 0 and worker 1 will output debug logs for testing.
There was a problem hiding this comment.
I just wonder if we should test broker's output as well.
Since broker is down in this test case, it is OK without it.
chronolaw
reviewed
May 28, 2024
|
There are some commented code in test case, I suggest to remove them before it merged. |
681cac7 to
d570fd7
Compare
@chronolaw, It is left for further enhancements, when we get them done. Not to be removed (I added comment about it). |
d570fd7 to
2af6d7e
Compare
chronolaw
approved these changes
May 28, 2024
| ngx.shared.dict:set("broker-pid", ngx.worker.pid()) | ||
| end | ||
|
|
||
| if id == 0 or id == 1 then |
There was a problem hiding this comment.
Yes, worker 0 and worker 1 will output debug logs for testing.
outsinre
approved these changes
May 28, 2024
bungle
added a commit
to bungle/lua-resty-events
that referenced
this pull request
May 28, 2024
### Summary - fix(tests): fix tests to not be order dependent on multi-worker scenario (Kong#46) - chore(callback): remove unnecessary assert when the type is already checked (Kong#50) - chore(queue): rename DEFAULT_QUEUE_LEN to more meaningful MAX_QUEUE_PREALLOCATE (Kong#52) - chore(callback): split get_callback_list to two functions to avoid unnecessary table creation (Kong#51) - fix(worker): do not premature kill threads when not exiting (Kong#47) - fix(broker): do not premature kill threads when not exiting (Kong#48) - fix(worker): separate communication and event processing to different timers (Kong#53) - caused by Kong#47
Merged
bungle
added a commit
to bungle/lua-resty-events
that referenced
this pull request
May 28, 2024
### Summary - fix(tests): fix tests to not be order dependent on multi-worker scenario (Kong#46) - chore(callback): remove unnecessary assert when the type is already checked (Kong#50) - chore(queue): rename DEFAULT_QUEUE_LEN to more meaningful MAX_QUEUE_PREALLOCATE (Kong#52) - chore(callback): split get_callback_list to two functions to avoid unnecessary table creation (Kong#51) - fix(worker): do not premature kill threads when not exiting (Kong#47) - fix(broker): do not premature kill threads when not exiting (Kong#48) - fix(worker): separate communication and event processing to different timers (Kong#53) - caused by Kong#47
bungle
added a commit
to bungle/lua-resty-events
that referenced
this pull request
May 28, 2024
### Summary - fix(tests): fix tests to not be order dependent on multi-worker scenario (Kong#46) - chore(callback): remove unnecessary assert when the type is already checked (Kong#50) - chore(queue): rename DEFAULT_QUEUE_LEN to more meaningful MAX_QUEUE_PREALLOCATE (Kong#52) - chore(callback): split get_callback_list to two functions to avoid unnecessary table creation (Kong#51) - fix(worker): do not premature kill threads when not exiting (Kong#47) - fix(broker): do not premature kill threads when not exiting (Kong#48) - fix(worker): separate communication and event processing to different timers (Kong#53) - caused by Kong#47
bungle
added a commit
that referenced
this pull request
May 28, 2024
### Summary - fix(tests): fix tests to not be order dependent on multi-worker scenario (#46) - chore(callback): remove unnecessary assert when the type is already checked (#50) - chore(queue): rename DEFAULT_QUEUE_LEN to more meaningful MAX_QUEUE_PREALLOCATE (#52) - chore(callback): split get_callback_list to two functions to avoid unnecessary table creation (#51) - fix(worker): do not premature kill threads when not exiting (#47) - fix(broker): do not premature kill threads when not exiting (#48) - fix(worker): separate communication and event processing to different timers (#53) - caused by #47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KAG-4480