Drop KongCredential from KIC and configuration/v1 CRDs #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainest
previously approved these changes
Sep 21, 2020
hbagdi
reviewed
Sep 21, 2020
| // Due to this reason, one can't perform a 'diff' with them. | ||
| // This function filters for basic-auth password changes and applies them | ||
| // to Kong as they happen. | ||
| func (n *KongController) handleBasicAuthUpdates(ctx context.Context, event Event) error { |
There was a problem hiding this comment.
So it seems like we introduced a bug when we added in the Secret-based credentials.
This function should be triggered when basic-auth creds in a secret change.
The bug has not come up because it applies to basic-auth credentials and DB-mode of Kong, which is not a common situation (I wonder where the users are who prompted me to add this function, we had quite a few reports for this problem in the past).
There was a problem hiding this comment.
Tracking this here: #865
Not a blocker for this PR.
hbagdi
previously approved these changes
Sep 21, 2020
The base branch was changed.
|
This needs to go into next. Please rebase and resolve the conflict. |
3c5aa58 to
ceecb6b
Compare
Done. PTAL now. |
rainest
previously approved these changes
Sep 22, 2020
|
Please remove 1de8dac from this PR. |
ceecb6b to
f59bf4e
Compare
hbagdi
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After this PR, KIC has no notion of KongCredential whatsoever and provides equivalent functionality by means of plain Secrets.
Which issue this PR fixes: fixes #823
Special notes for your reviewer:
Consider merging without squashing.