Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync changes to basic-auth passwords in DB-mode #865

Closed
hbagdi opened this issue Sep 21, 2020 · 3 comments
Closed

Sync changes to basic-auth passwords in DB-mode #865

hbagdi opened this issue Sep 21, 2020 · 3 comments
Assignees
Labels
bug Something isn't working priority/medium

Comments

@hbagdi
Copy link
Member

hbagdi commented Sep 21, 2020

53124f1 introduced the support for changing basic-auth passwords and syncing them as needed. With #823, we removed the associated code but it needs to be added back in.
The code was removed because the code didn't do what it was suppose to. The code only made updates to Kong for KongCredential resource, which are not used widely anymore. The code should be changed to do the same for Secret-based credentials and added back in.

Please see this comment for more context:
82c211b#r492376403

@hbagdi hbagdi added the bug Something isn't working label Sep 21, 2020
@stale stale bot added the stale Will be closed unless advocated for within 7 days label Mar 20, 2021
@mflendrich
Copy link
Contributor

Let's verify if this is still a problem today.

@stale stale bot removed the stale Will be closed unless advocated for within 7 days label Mar 22, 2021
@Kong Kong deleted a comment from stale bot Mar 25, 2022
@shaneutt shaneutt self-assigned this Mar 25, 2022
@shaneutt
Copy link
Contributor

Because this one is difficult to assess from the original posting I think we should talk about it. I'm going to try and shepherd this one forward a bit and will bring it up at our next planning meeting.

@mflendrich
Copy link
Contributor

Secret-based credential management works now, this is outdated. Therefore closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority/medium
Projects
None yet
Development

No branches or pull requests

3 participants