chore: read admin api response body from error #6244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
programmer04
previously approved these changes
Jun 25, 2024
|
Well, given we haven't released go-kong v1 yet, we can release a breaking change I believe 🤔 Kong/go-kong#453. Let's hold on with merging this PR and release go-kong first so it's done in a single step. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6244 +/- ##
======================================
Coverage ? 73.6%
======================================
Files ? 200
Lines ? 19912
Branches ? 0
======================================
Hits ? 14673
Misses ? 4253
Partials ? 986 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Don't rely on
ReloadDeclarativeRawConfigto return the error body whenerr != nilas it might be considered a Go anti-pattern to use variables when an error is returned. Instead, rely on theAPIErrorbeing returned in cases where the error body is available.Which issue this PR fixes:
Follow up to #6237 (comment).