-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: try recovering from gateway sync failure only on UpdateError #6237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
fix/only-recover-on-updateerror
branch
2 times, most recently
from
June 24, 2024 14:09
bcf1836
to
15f7a40
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6237 +/- ##
========================================
- Coverage 73.6% 39.1% -34.5%
========================================
Files 200 199 -1
Lines 19909 19903 -6
========================================
- Hits 14654 7798 -6856
- Misses 4264 11168 +6904
+ Partials 991 937 -54 ☔ View full report in Codecov by Sentry. |
czeslavo
force-pushed
the
fix/only-recover-on-updateerror
branch
2 times, most recently
from
June 24, 2024 16:59
389d60a
to
228a71e
Compare
czeslavo
force-pushed
the
fix/only-recover-on-updateerror
branch
2 times, most recently
from
June 25, 2024 09:41
7459c39
to
7aa5f69
Compare
czeslavo
force-pushed
the
fix/only-recover-on-updateerror
branch
from
June 25, 2024 09:46
7aa5f69
to
16ce72a
Compare
czeslavo
force-pushed
the
fix/only-recover-on-updateerror
branch
from
June 25, 2024 10:52
16ce72a
to
3067931
Compare
programmer04
approved these changes
Jun 25, 2024
czeslavo
added a commit
that referenced
this pull request
Jun 27, 2024
) (cherry picked from commit 420b44c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We should try recovering with the fallback configuration (either generated or the persisted last valid one) only if we get an expected
UpdateError
from theUpdateStrategy
. Otherwise, we can assume the error is unrecoverable through the fallback configuration (e.g. transient network errors, gateways returning 5xx, etc.).It relies on Kong/go-kong#452.
Which issue this PR fixes:
Fixes #6218.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR