Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate --use-last-valid-config-for-fallback flag #6168

Merged
merged 6 commits into from
Jun 7, 2024

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Jun 7, 2024

What this PR does / why we need it:

Adds validation for the --use-last-valid-config-for-fallback flag that is only relevant when the FallbackConfiguration feature gate is turned on.

Which issue this PR fixes:

Part of #5854.

@czeslavo czeslavo added this to the KIC v3.2.x milestone Jun 7, 2024
@czeslavo czeslavo self-assigned this Jun 7, 2024
@czeslavo czeslavo marked this pull request as ready for review June 7, 2024 12:25
@czeslavo czeslavo requested a review from a team as a code owner June 7, 2024 12:25
@czeslavo czeslavo force-pushed the validate-use-last-valid branch from 4c816da to 36593d2 Compare June 7, 2024 12:28
programmer04
programmer04 previously approved these changes Jun 7, 2024
internal/manager/config.go Outdated Show resolved Hide resolved
internal/manager/config.go Outdated Show resolved Hide resolved
internal/manager/config_validation.go Outdated Show resolved Hide resolved
Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.6%. Comparing base (74f527d) to head (db9afe3).
Report is 4 commits behind head on main.

Current head db9afe3 differs from pull request most recent head 52b05f3

Please upload reports for the commit 52b05f3 to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #6168     +/-   ##
=======================================
- Coverage   73.7%   73.6%   -0.1%     
=======================================
  Files        198     198             
  Lines      19724   19742     +18     
=======================================
- Hits       14547   14546      -1     
- Misses      4196    4213     +17     
- Partials     981     983      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

programmer04
programmer04 previously approved these changes Jun 7, 2024
programmer04
programmer04 previously approved these changes Jun 7, 2024
pmalek
pmalek previously approved these changes Jun 7, 2024
internal/manager/config.go Show resolved Hide resolved
@czeslavo czeslavo merged commit 96ce87b into main Jun 7, 2024
38 checks passed
@czeslavo czeslavo deleted the validate-use-last-valid branch June 7, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants