-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(kic): fallback configuration guide #7463
Conversation
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
cd329fb
to
97f8d60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of review (without taking this for a spin):
- I'd add section to this doc so that it's easier to follow. Currently this only has
Example scenario
which doesn't tell the reader what stage of the scenario they're at (am I deploying manifests, testing them, patching them or verifying that fallback config works?) - I'd dd a separate (named) section which shows how last known config backfill + fallback works on concrete example. This should be separate in my eyes from what already described and the difference should be noted (
X
route still works, having previous config filled in).
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
740cd7a
to
de2a0e5
Compare
Added more granular sections as well as the whole section about backfilling. Thanks for the comments, I hope I addressed all of them. 🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Can we already add docs for the feature gate at https://github.com/Kong/docs.konghq.com/blob/86f6865fae98afe729d77583563d982060465578/app/_src/kubernetes-ingress-controller/reference/feature-gates.md ?
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
Updated the feature gates reference (we were missing some from KIC 3.1): 9bbe69b |
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
app/_src/kubernetes-ingress-controller/guides/high-availability/fallback-config.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Patryk Małek <patryk.malek@konghq.com>
4ef76e2
to
b4bf146
Compare
b4bf146
to
959ddc3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an awesome guide, thank you.
The config debug endpoint isn't working (known issue), but otherwise it all worked as expected (with my latest commit to fix Helm values)
Labeling
|
Description
Adds a guide explaining the new
FallbackConfiguration
feature usage.Part of Kong/kubernetes-ingress-controller#5934.
Testing instructions
Preview link: https://deploy-preview-7463--kongdocs.netlify.app/kubernetes-ingress-controller/unreleased/guides/high-availability/fallback-config/
Checklist