-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(diag) expose fallback objects #6159
Conversation
e4bf51b
to
c4794fd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6159 +/- ##
=======================================
- Coverage 73.8% 69.7% -4.2%
=======================================
Files 198 200 +2
Lines 19798 19885 +87
=======================================
- Hits 14619 13865 -754
- Misses 4197 5031 +834
- Partials 982 989 +7 ☔ View full report in Codecov by Sentry. |
We should make sure that no fallback objects are reported after we successfully push non-fallback configuration. |
c4794fd
to
fc34d70
Compare
acb9d78
to
3133007
Compare
Alright, so discarding all the hash stuff and separate problem endpoint,
I'm not sure if there are currently or would ever be cases where we'd have a mix of excluded and backfilled objects--the code suggests we can only have one or the other for the current fallback state. |
feat(diag) rework fallback endpoint wip: enable config dumps for isolated wip: diag url for isolated wip: poke the diag URL wip: clear hash and test output wip: remove fallback if clear wip: remove separate problems endpoint
3133007
to
a353501
Compare
As a result of the review, I prepared a suggested changes set, but we agreed with @pmalek to merge it to |
a329ccb
to
981e3a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
overall LGMT
What this PR does / why we need it:
The bit requested in #6101 (comment)
Which issue this PR fixes:
Fix #5932
Special notes for your reviewer:
Nothing re #4473 as requested, and no tests at present, nor a fix for the bit that's broken per #5932 (comment), but putting something up given requested timeline.
Unfortunately didn't see the design edit on #5932, but this at least provides the piping needed to ship stuff to the diag server to try and reshape it into that.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR