Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use TakeSnapshotIfChanged to avoid taking redundant snapshot #6092

Merged
merged 1 commit into from
May 28, 2024

Conversation

programmer04
Copy link
Member

What this PR does / why we need it:

Replaces usage of TakeSnapshot with TakeSnapshotIfChanged that was introduced in

Which issue this PR fixes:

Closes #6080

@programmer04 programmer04 added the area/feature New feature or request label May 27, 2024
@programmer04 programmer04 added this to the KIC v3.2.x milestone May 27, 2024
@programmer04 programmer04 self-assigned this May 27, 2024
@programmer04 programmer04 requested a review from a team as a code owner May 27, 2024 10:17
@programmer04 programmer04 enabled auto-merge (squash) May 27, 2024 10:27
internal/dataplane/fallback/fallback.go Outdated Show resolved Hide resolved
internal/dataplane/sendconfig/kong.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/store/cache_stores_snapshot.go Outdated Show resolved Hide resolved
internal/dataplane/sendconfig/kong.go Outdated Show resolved Hide resolved
internal/dataplane/fallback/fallback.go Outdated Show resolved Hide resolved
internal/dataplane/sendconfig/kong.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client.go Outdated Show resolved Hide resolved
internal/dataplane/kong_client.go Show resolved Hide resolved
internal/dataplane/kong_client.go Show resolved Hide resolved
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 6.1%. Comparing base (763d7d1) to head (d43abef).
Report is 16 commits behind head on main.

Current head d43abef differs from pull request most recent head aa7d6d7

Please upload reports for the commit aa7d6d7 to get more accurate results.

Files Patch % Lines
internal/store/cache_stores_snapshot.go 0.0% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #6092      +/-   ##
========================================
- Coverage   74.6%    6.1%   -68.5%     
========================================
  Files        194     106      -88     
  Lines      18861    9731    -9130     
========================================
- Hits       14072     595   -13477     
- Misses      3814    9023    +5209     
+ Partials     975     113     -862     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@programmer04 programmer04 merged commit fd03b86 into main May 28, 2024
49 checks passed
@programmer04 programmer04 deleted the impr-snapshot branch May 28, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate cache snapshot before building current config only if cache changed
3 participants