Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send config to Kong Gateway when no changes occurred #6095

Open
2 of 4 tasks
programmer04 opened this issue May 27, 2024 · 0 comments
Open
2 of 4 tasks

Do not send config to Kong Gateway when no changes occurred #6095

programmer04 opened this issue May 27, 2024 · 0 comments
Labels

Comments

@programmer04
Copy link
Member

programmer04 commented May 27, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Does this enhancement require public documentation?

  • I have added an Acceptance Criteria item for adding and/or adjusting public documentation (if applicable)

Problem Statement

Method

func (c *KongClient) Update(ctx context.Context) error {

can use optimization that for now is reserved for Fallback configuration

in its main path to avoid redundant submissions of config to Kong Gateway

Proposed Solution

  • move the configuration change check to the main code path

Additional information

There is a flag mysterious flag

flagSet.BoolVar(&c.EnableReverseSync, "enable-reverse-sync", false, `Send configuration to Kong even if the configuration checksum has not changed since previous update.`)
that seems to be pretty similar. Decide what about it. See also internal/dataplane/sendconfig/config_change_detector.go which suppose to do the same, but in later stage of sending a config.

Acceptance Criteria

  • In case of the same configuration method Update returns without sending configuration to Kong
  • Decision about flag --enable-reverse-sync is made
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant