Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gateway-related conformance tests #2774

Merged
merged 2 commits into from
Aug 8, 2022
Merged

Gateway-related conformance tests #2774

merged 2 commits into from
Aug 8, 2022

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Aug 4, 2022

What this PR does / why we need it:
All the conformance tests related to the gateways are passing and enabled by default.

Which issue this PR fixes:
Fixes #2777

Special notes for your reviewer:

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

@mlavacca mlavacca force-pushed the gateway-conformance-tests branch from 9b12ac0 to 34c6e34 Compare August 5, 2022 14:26
@mlavacca mlavacca temporarily deployed to Configure ci August 5, 2022 14:26 Inactive
@mlavacca mlavacca force-pushed the gateway-conformance-tests branch from 34c6e34 to d174358 Compare August 5, 2022 14:34
@mlavacca mlavacca temporarily deployed to Configure ci August 5, 2022 14:34 Inactive
@mlavacca mlavacca temporarily deployed to Configure ci August 5, 2022 14:55 Inactive
@mlavacca mlavacca force-pushed the gateway-conformance-tests branch from d174358 to f4c387a Compare August 5, 2022 15:03
@mlavacca mlavacca temporarily deployed to Configure ci August 5, 2022 15:03 Inactive
@mlavacca mlavacca marked this pull request as ready for review August 5, 2022 15:25
@mlavacca mlavacca requested a review from a team as a code owner August 5, 2022 15:25
@mlavacca mlavacca temporarily deployed to Configure ci August 5, 2022 15:26 Inactive
@mlavacca mlavacca marked this pull request as draft August 8, 2022 06:38
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca force-pushed the gateway-conformance-tests branch from f4c387a to 6370278 Compare August 8, 2022 10:59
@mlavacca mlavacca temporarily deployed to Configure ci August 8, 2022 10:59 Inactive
@mlavacca mlavacca mentioned this pull request Aug 8, 2022
1 task
@mlavacca mlavacca temporarily deployed to Configure ci August 8, 2022 11:21 Inactive
@mlavacca mlavacca marked this pull request as ready for review August 8, 2022 12:30
@mlavacca
Copy link
Member Author

mlavacca commented Aug 8, 2022

Note for the reviewers: this PR only aims at implementing the minimal set of specifics to pass the conformance tests. Some corner cases in the gateway status update are not handled here and are out of scope for this PR. I created two different issues to track them:

Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Mostly minor comments and questions and a request for some more testing.

internal/controllers/gateway/gateway_utils.go Outdated Show resolved Hide resolved
internal/controllers/gateway/gateway_utils.go Outdated Show resolved Hide resolved
internal/controllers/gateway/gateway_utils.go Show resolved Hide resolved
@mlavacca mlavacca temporarily deployed to Configure ci August 8, 2022 14:32 Inactive
@mlavacca mlavacca requested a review from shaneutt August 8, 2022 14:33
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
@mlavacca mlavacca force-pushed the gateway-conformance-tests branch from d85b961 to a1ce3a1 Compare August 8, 2022 14:39
@mlavacca mlavacca temporarily deployed to Configure ci August 8, 2022 14:39 Inactive
@mlavacca mlavacca temporarily deployed to Configure ci August 8, 2022 15:02 Inactive
@mlavacca mlavacca merged commit 03e9900 into main Aug 8, 2022
@mlavacca mlavacca deleted the gateway-conformance-tests branch August 8, 2022 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all conformance tests for v1beta1.Gateway are run and required for every PR
2 participants