-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gateway-related conformance tests #2774
Conversation
9b12ac0
to
34c6e34
Compare
34c6e34
to
d174358
Compare
d174358
to
f4c387a
Compare
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
f4c387a
to
6370278
Compare
Note for the reviewers: this PR only aims at implementing the minimal set of specifics to pass the conformance tests. Some corner cases in the gateway status update are not handled here and are out of scope for this PR. I created two different issues to track them: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Mostly minor comments and questions and a request for some more testing.
Signed-off-by: Mattia Lavacca <lavacca.mattia@gmail.com>
d85b961
to
a1ce3a1
Compare
What this PR does / why we need it:
All the conformance tests related to the gateways are passing and enabled by default.
Which issue this PR fixes:
Fixes #2777
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR