Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Gateway Listener Conditions #2558

Closed
1 task
rainest opened this issue Jun 9, 2022 · 1 comment · Fixed by #4564
Closed
1 task

Review Gateway Listener Conditions #2558

rainest opened this issue Jun 9, 2022 · 1 comment · Fixed by #4564
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API nice-to-have

Comments

@rainest
Copy link
Contributor

rainest commented Jun 9, 2022

#2557 uses Gateway Listener conditions to indicate when a Listener cannot become ready due to missing Kong configuration. It does not add cases to handle all the Listener conditions and reasons available upstream in https://github.com/kubernetes-sigs/gateway-api/blob/v0.4.3/apis/v1alpha2/gateway_types.go#L710-L838

We should review the others, determine if there are other conditions+reasons appropriate for failure conditions in our Gateway reconciliation and set them appropriately if so.

Stub AC:

@rainest rainest added area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API nice-to-have labels Jun 9, 2022
@mlavacca
Copy link
Member

mlavacca commented Aug 8, 2022

ResolvedRefCondition has been added by #2774 to pass the conformance tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gateway-api Relating to upstream Kubernetes SIG Networking Gateway API nice-to-have
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants