-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps) update deck to v1.11.0 #2286
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rainest
force-pushed
the
chore/deck-update
branch
from
February 22, 2022 22:21
e9c4a70
to
4abfe4f
Compare
shaneutt
previously approved these changes
Feb 23, 2022
rainest
force-pushed
the
chore/deck-update
branch
from
February 23, 2022 16:38
7059661
to
4abfe4f
Compare
rainest
force-pushed
the
chore/deck-update
branch
from
February 23, 2022 17:08
4abfe4f
to
9387171
Compare
shaneutt
previously approved these changes
Feb 23, 2022
Something broke after I originally tested the defaults change. Closed pending new version with a fix Kong/deck#596 |
shaneutt
approved these changes
Feb 24, 2022
Licenses differ between commit 96ae8ec and base:
|
Licenses differ between commit 96ae8ec and base:
|
GGabriele
approved these changes
Feb 24, 2022
scirner22
pushed a commit
to scirner22/kubernetes-ingress-controller
that referenced
this pull request
Mar 18, 2022
* chore(deps) update deck to v1.11.0 * update mergo deps Co-authored-by: Gabriele Gerbino <gabrielegerbino@gmail.com>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Updates deck, including some signature changes.
Special notes for your reviewer:
This incorporates Kong/deck#573, which means that defaults are now populated by based on what Kong reports the default as if not present. This is good, because it avoids the long-standing "unrelated change updates some value that should be 'empty' according to the requested object" problem (e.g. the removal of
https_verify_certificate
in the example in #2248 (comment)).KIC has its own set of defaults embedded in the code. Many of these were previously in place only to prevent config thrashing, but some actually differ from Kong defaults, e.g.
kubernetes-ingress-controller/internal/dataplane/parser/translate.go
Lines 69 to 75 in 4f7878c
strip_path
default.This PR does not touch any of the defaults in KIC, as they should be benign (if unnecessary) if they match Kong's, but are essentially required if they do not, because removing them would constitute a breaking change. We may opt to try and prune these down to only the required (different) KIC defaults after.
PR Readiness Checklist:
Complete these before marking the PR as
ready to review
:CHANGELOG.md
release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR