fix(builder) set strip_path after defaults #596
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: the original rationale was wrong, I didn't realize we needed to re-add the mergo replace to KIC modules. This is now only the test.
Kong/kubernetes-ingress-controller#2286 failed when trying to add v1.11.0 to KIC. Something appears to have happened after I tested with #573.
Within ingresRoute, the value is
false
as expected after it's set to the result ofgetStripPathBasedOnProtocols()
. It flips back totrue
after https://github.com/Kong/deck/blob/v1.11.0/file/builder.go#L786I thought this maybe meant something didn't work as expected with #580, but as these were already
*bool
any non-nil value is not zero, so I'm not sure why the default was merging over the original value.The change here does fix the issue, but I'd like to better understand what's going on here if possible.