Add dimmer strategy configuration for ubisys D1(-R) #528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 27, 2020
Koenkk
reviewed
Dec 28, 2020
docs/devices/D1.md
Outdated
|
|
||
| Bit(s) | Description | ||
| ---|--- | ||
| 0 | When this bit is set, the dimmer supports AC forward phase control. |
There was a problem hiding this comment.
Can we translate this in the converters to something more user friendly?
|
Can you rebase this branch against master? Most is already in there: https://github.com/Koenkk/zigbee2mqtt.io/blob/master/docs/devices/D1.md#capabilities_forward_phase_control-binary (generated from exposes info) |
|
Didn't know that most part of the file was generated. I think it's ok now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.