Add dimmer configuration for ubisys D1(-R) #1984
Conversation
|
Relates to Koenkk/zigbee-herdsman#277 & Koenkk/zigbee2mqtt.io#528 |
converters/toZigbee.js
Outdated
| @@ -2528,6 +2528,32 @@ const converters = { | |||
| ], manufacturerOptions.ubisys)); | |||
| }, | |||
| }, | |||
| ubisys_dimmer_setup: { | |||
| key: ['ubisys_dimmer_setup'], | |||
There was a problem hiding this comment.
I propose to chnage this to ubisys_dimmer_mode so we don't have a nested object. This allows it to add it to exposes, (as enum, see example here:
zigbee-herdsman-converters/devices.js
Line 735 in 38752ab
There was a problem hiding this comment.
Good idea, will try it (new to javascript ;-))
converters/toZigbee.js
Outdated
| meta.logger.warn( | ||
| `ubisys: Dimmer setup read for '${meta.options.friendlyName}': ${JSON.stringify(utils.toSnakeCase(dataRead))}`); | ||
| }; | ||
| log(await entity.read('manuSpecificUbisysDimmerSetup', ['capabilities'])); |
There was a problem hiding this comment.
Instead of logging, just read here and add a fromZigbee converter to translate it to something user friendly. (https://github.com/Koenkk/zigbee2mqtt.io/pull/528/files#r549327509)
|
Added convertor for the different attributes and removed the nested object to support the exposes. Works nicely in the ui. |
|
Not sure if this the best option to have the dimmer phase control mode available for configuration in exposes. This is basically a one time setup, so it might be better to have it in the devices.yaml file. That's also why it was initially coded like the |
I don't agree on this. These options are stored on the device side, not on the Z2M side. Allowing these options to be put in devices.yaml would add a lot of code on the Z2M side to sync the current selected options (there is also currently no mechanism for this). PR looks good to me, let me know if it can be merged. |
|
Ok, I see. I was wondering if there's some sort of device configuration available to place configuration options like this. On/Off, brightness,... are used on a daily basis, but things like the dimmer setup, ballast configuration are typically only configured during installation and it might not be bad to prevent accidental change (in case of the dimmer setup this could even destroy the device!). If it's fine for you, it can be merged. |
|
Thanks! |
No description provided.