Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

WSON-10: Remove mask over thermal vias #435

Merged
merged 1 commit into from
Mar 16, 2018
Merged

Conversation

evanshultz
Copy link
Collaborator

The 3 vias on this footprint created a KLC violation. I noted this when the footprints were moved to this repo and am now fixing it. The actual PCB wouldn't change due to this, since a big central pad with mask already exists, but it fixes the KLC violation and doesn't hurt. See page 32 of the datasheet at http://www.ti.com/lit/ds/symlink/tps62177.pdf.


Thanks for creating a pull request to contribute to the KiCad libraries! To speed up integration of your PR, please check the following items:

  • Provide a URL to a datasheet for the footprint(s) you are contributing
  • An example screenshot image is very helpful
  • If there are matching symbol or 3D model pull requests, provide link(s) as appropriate
  • Check the output of the Travis automated check scripts - fix any errors as required

@Ratfink
Copy link
Collaborator

Ratfink commented Mar 16, 2018

I don't know which KLC rule this was violating (please share!), but the change surely can't hurt. Thanks!

@Ratfink Ratfink merged commit 961c33e into KiCad:master Mar 16, 2018
@evanshultz evanshultz deleted the wson10 branch March 16, 2018 21:14
@evanshultz
Copy link
Collaborator Author

Thanks!

Beats me. I just noted

thermal vias missing mask:
'WSON-10-1EP_2x3mm_P0.5mm_ThermalVias'

@poeschlr
Copy link
Collaborator

Hm that might be a false positive. (I have not looked at the footprints)
The via pads should not have mask enabled. If travis still flags them then you can ignore this error. (It might be possible to do something similar with this error message like @Ratfink did with the paste messages.)

@poeschlr
Copy link
Collaborator

Ok i should have looked before commenting. I fear this really was a false positive and this "fix" should not have been merged.

The reason is that we normally want the mask controlled by other pads. (Either by the large pad that also does the copper part of the EP or by a separate mask only pad if the footprint requires tighter control over where mask cutout is.)

@evanshultz
Copy link
Collaborator Author

??? The big pin 11 pad already had mask removed on the top and not the bottom. This doesn't change the actual footprint at all when placed on a board. (Whether we want soldermask placed on the bottom and not the top is a different question.)

I looked in the SON folder at the first two I found and they both had mask removed on the vias: https://github.com/KiCad/kicad-footprints/blob/master/Package_SON.pretty/Texas_DSC0010J_ThermalVias.kicad_mod and https://github.com/KiCad/kicad-footprints/blob/master/Package_SON.pretty/Texas_S-PVSON-N10_ThermalVias.kicad_mod. Now I checked the third one (https://github.com/KiCad/kicad-footprints/blob/master/Package_SON.pretty/Texas_S-PVSON-N8_ThermalVias.kicad_mod) and it doesn't have mask on the vias.

I'm not sure I see the problem. The big pad covers these vias already. If the vias should be open, and solder paste loss isn't too bad, the then the user can modify the bottom side. If the user wants tented or plugged vias I've usually handled that with a note on the fab drawing and KiCad can't note it otherwise.

So if we want a default rule about how thermal vias are handled in library parts, that's fine. And a check for the via design chosen would also be good. Right now the library is not consistent, but this PR doesn't change this particular footprint and it doesn't make the library more or less homogenous.

@poeschlr
Copy link
Collaborator

It does not make a difference for this footprint.
As there are footprints where some of the thermal vias are outside the masked areas, it would make a difference for them.

Having one rule that works for all footprints would make it easier to make a travis check for it. (It also makes describing the rule easier)
In this case that one rule is that we do not add mask to any of the tht pads used for vias. (I don't quite remember who came up with that particular way of doing it. It might have been jan and oliver.)

I am sorry that we did not communicate this better. (I just looked at the KLC and we seem to have forgotten that part. I added the stuff about separating paste pads but i seem to have forgotten to add the details about thermal via footprints.)


Some time ago i made all footprints comply with that (sadly unwritten) rule set. This was the PR in question #285

@Ratfink Ratfink mentioned this pull request Apr 22, 2018
4 tasks
@myfreescalewebpage myfreescalewebpage added the Enhancement Improves existing footprint in the library label May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Enhancement Improves existing footprint in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants