-
Notifications
You must be signed in to change notification settings - Fork 712
Add EP size to fp names. Fix paste definition. #285
Conversation
@jkriege2 could it be that travis is not working for this PR? (It says everything is ok but i think there should be more output in the report. I also think it should report some errors.) |
This should be ready now. Remaining travis errors are from the THT pads used for thermal vias footprints. (We might need to add an exception to that rule check.) I checked the footprints multiple times and i am sure they are better now then they were. I don't suggest that there is no error left in them. (I hope i did not introduce new errors however.) |
OK. I only did a very cursory check. We do need to update the scripts to ignore thermal pad errors because there are several causes where bogus errors are created. |
I know. I think one way to reduce false positives is by turning off this error if the footprint name contains _ThermalVias. Maybe in addition check if a smd pad on top and bottom with the same pad number exist. (A perfect check would also test the position of the THT pads against these pads but i think that might be too much work.) |
I agree. For robustness, I think checking for a via with matching pin number inside a copper pad is best. Also, we should not generate an error if a paste opening if embedded inside a copper pad. The paste opening should not have a pin number, either. While we're talking about scripts, should the check scripts be a pinned repo at https://github.com/KiCad? Should the footprint generator scripts be migrated to https://github.com/KiCad as well, and pinned there too? |
@poeschlr The mask is opened under the EP. So in the official KiCad library, mask should be over vias by default. Mask is only removed over vias indirectly if the mask is removed for another reason. I'm wanting to make sure the latest comment at KiCad/kicad-symbols#289 is answered properly. |
Yes normally the vias them selves are only copper. I guess the guy in 289 wants to make vias that are tended on the top side to avoid paste to be wicked down the open via. One thing i found is this discussion on the fourm https://forum.kicad.info/t/a-help-with-qfn-footprint-with-thermal-vias-and-solder-paste/5293 It shows that we could choose from a lot of different options (I seem to remember an even better and more detailed discussion but i can't even find that any more.) What i found this time around: Edit: https://www.infineon.com/dgdl/an-1091.pdf?fileId=5546d462533600a401535595b4ad1043 The more i read about it the more i think with small enough drill sizes one can leave the vias open on both sides. (But better would be to fill the vias with copper.) |
If you want to build a footprint exactly as in a datasheet prefix the footprint name with the manufacturer name. |
@poeschlr |
Yes the bottom pad and the vias should not have mask active unless there is a good reason given for it. The top pad has mask selected unless the datasheet asks for a mask cutout of a specific size. In such cases it makes sense to create a mask only pad that handles this. (If in doubt, Edit: top side tenting is not really possible with the tools provided by kicad. (The thing @awygle shows in his post) I wrote a class to handle exposed pads. This already provides the functionality to keep vias free from paste. I think adding the option to top tend vias might even be less effort then the paste stuff as this should be handled by the cut function alone. |
In the end this PR will add the EP size definition to all footprints that have an external pad.
I use this also to fix the paste definitions of the footprints that i touch.
When this is finished, i will also make a PR for the packages3d repo and the symbol repo to get them in line with this PR.