Clarify wording about local_access "value_type" #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because there is no access mode for `local_accessor`, the `value_type` is always the same as `DataT`. (The only way to get a read-only `local_accessor` is to use a `DataT` that is `const`.) Remove a comment in the synopsis that made it appear that `value_type` might be different from `DataT`. Also change the return type of `local_accessor::get_pointer` from `DataT` to `value_type`. Although these types are the same, it seems clearer to be consistent with `accessor::get_pointer`, where the return type is `value_type`.
nliber
approved these changes
Jun 13, 2024
psalz
approved these changes
Jun 20, 2024
keryell
pushed a commit
that referenced
this pull request
Sep 10, 2024
Clarify wording about local_access "value_type"
gmlueck
pushed a commit
that referenced
this pull request
Nov 7, 2024
Clarify wording about local_access "value_type" (cherry picked from commit 7c670cc)
gmlueck
pushed a commit
that referenced
this pull request
Nov 7, 2024
Clarify wording about local_access "value_type" (cherry picked from commit 7c670cc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because there is no access mode for
local_accessor, thevalue_typeis always the same asDataT. (The only way to get a read-onlylocal_accessoris to use aDataTthat isconst.)Remove a comment in the synopsis that made it appear that
value_typemight be different fromDataT.Also change the return type of
local_accessor::get_pointerfromDataTtovalue_type. Although these types are the same, it seems clearer to be consistent withaccessor::get_pointer, where the return type isvalue_type.