Fix typo with "accessor::get_pointer" #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It appears that we introduced a typo with KhronosGroup#432 with the return type of `accessor::get_pointer`. In the synopsis, we specified it as: ``` global_ptr<DataT> get_pointer() const noexcept ``` But in the description, it seems that we made a typo and said: ``` global_ptr<access::decorated::legacy> get_pointer() const noexcept ``` I believe these are both wrong, and it should be: ``` global_ptr<value_type> get_pointer() const noexcept ``` Using `value_type` is better than `DataT` because `value_type` is const when the accessor is read-only.
Naghasan
approved these changes
Apr 16, 2024
AlexeySachkov
pushed a commit
to intel/llvm
that referenced
this pull request
Apr 25, 2024
Deprecated a few APIs which are not in SYCL 2020 spec: - `accessor::get_multi_ptr()` should be available only when `AccessTarget == target::device`. - `marray<DataT, N>::operator++/--`should be available only when `DataT != bool`. Updated `multi_ptr::get_pointer()` to use correct type alias in accordance with KhronosGroup/SYCL-Docs#549 --------- Signed-off-by: Hu, Peisen <peisen.hu@intel.com>
greglueck
approved these changes
May 9, 2024
TApplencourt
approved these changes
May 9, 2024
AerialMantis
approved these changes
May 16, 2024
|
I have the feeling that https://github.com/KhronosGroup/SYCL-Docs/pull/432/files#diff-498c175f1b8454ffa58e5f5d9db2c295f04199f9833a50e48159b9534a4cb496R68 looks weird too. |
Actually, that is not wrong because |
keryell
pushed a commit
that referenced
this pull request
Sep 10, 2024
Fix typo with "accessor::get_pointer"
gmlueck
added a commit
that referenced
this pull request
Nov 7, 2024
Fix typo with "accessor::get_pointer" (cherry picked from commit 1b8c0c0)
gmlueck
added a commit
that referenced
this pull request
Nov 7, 2024
Fix typo with "accessor::get_pointer" (cherry picked from commit 1b8c0c0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that we introduced a typo with #432 with the return type of
accessor::get_pointer. In the synopsis, we specified it as:But in the description, it seems that we made a typo and said:
I believe these are both wrong, and it should be:
Using
value_typeis better thanDataTbecausevalue_typeis const when the accessor is read-only.