Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Texture Mapping #199

Open
apptaro opened this issue Jul 19, 2018 · 16 comments
Open

Incorrect Texture Mapping #199

apptaro opened this issue Jul 19, 2018 · 16 comments
Labels

Comments

@apptaro
Copy link

apptaro commented Jul 19, 2018

Some of converted GLTF files have incorrect texture mappings:
summary

@apptaro
Copy link
Author

apptaro commented Jul 19, 2018

Version: COLLADA2GLTF-v2.1.2-windows-Release-x64

DAE and GLTF data attached:
data-uv.zip

Possibly related issue: #174, #175, #116

@apptaro
Copy link
Author

apptaro commented Jul 19, 2018

All DAE files are exported from 3ds Max.
BabylonJS, Three.js and Cesium all render in the same way.

@lasalvavida
Copy link
Contributor

This should be mostly fixed in the latest version of #180 that allows for multiple texture maps.

screenshot from 2018-07-20 08 29 01

screenshot from 2018-07-20 08 29 57

screenshot from 2018-07-20 08 30 24

There's a little bit of weirdness on one of the bulbs in the lamp model still, and I'm not sure what the cause is yet.

screenshot from 2018-07-20 08 30 49

@apptaro
Copy link
Author

apptaro commented Jul 20, 2018

@lasalvavida wow, very nice, I'm looking forward to the next release. I have many other cases with this issue, so once the fix is released, I will try them all.

@apptaro
Copy link
Author

apptaro commented Aug 3, 2018

any plan to release the fix?

@lasalvavida
Copy link
Contributor

Hey @apptaro. It will be released once I have tested it more thoroughly.

If you want to use it/help test it in the meantime, you can grab pre-built artifacts for windows off of the appveyor job for the pull request like this one: Windows x64 Release multiple-maps

@apptaro
Copy link
Author

apptaro commented Aug 5, 2018

@lasalvavida Yes, I would like to use and test it. I downloaded the one above, but it has the issue #200 and was not usable.

@lasalvavida
Copy link
Contributor

Sounds good, #200 is next on my list.

@apptaro
Copy link
Author

apptaro commented Aug 17, 2018

@lasalvavida Let me know when I can test it out.

@apptaro
Copy link
Author

apptaro commented Aug 21, 2018

@lasalvavida Now I have figured out how to get the latest build from appveyor job, and tested it out. About 50 models are fixed. I have some models that still have the same issue, and some different issues. I will let you know when I am done testing.

@lasalvavida
Copy link
Contributor

Thanks @apptaro - the testing is very much appreciated!

@Ld-LaoWu
Copy link

I'm very looking forward that,but this is my stuff for multiple-maps and let that support THREE.js

@apptaro
Copy link
Author

apptaro commented Aug 24, 2018

@lasalvavida After testing all my models, only cases with this issue are dress-pendant-light-l-black.dae (above) and dress-pendant-light-l-white.dae (attached here data2.zip)

Tested with Build 2.0.314, COLLADA2GLTF-master-windows-Release-x64.zip

@Ld-LaoWu
Copy link

image
@lasalvavida it'my model .lightmap and diffusemap ,SO I have two layers of texture uvs for that and i I have modifieded the struct of outgltf and made it satisfied with it. and I want to compile your program so that i can control what i can output.can you give me a corrent program on windows? Waiting online,(i can not solve the erro about camke's Compiling)

@lasalvavida
Copy link
Contributor

@mycleaerlife, you can download Windows builds for any commit from the corresponding AppVeyor job artifacts tab like this one.

@Ld-LaoWu
Copy link

@lasalvavida I‘m sorry for that's wrong about my test, can i get source code ,and Compling it by myself.and sorry for my english
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants