lint: Ignore solhint issues for mock contracts

Most of these issues are intentional and are okay to ignore. This also
sets the solhint ignoreConstructors option to true for the
func-visibility rule, as we are using solidity >=0.7.0

tests/e2e-evm/.solhint.json

@@ -1,3 +1,6 @@
 {
-  "extends": "solhint:recommended"
+  "extends": "solhint:recommended",
+  "rules": {
+    "func-visibility": ["warn", { "ignoreConstructors": true }]
+  }
 }

tests/e2e-evm/contracts/ABI_BasicTests.sol

@@ -13,8 +13,10 @@ contract Caller {
         (bool success, bytes memory result) = to.call{value: msg.value}(data);
 
         if (!success) {
-            if (result.length == 0) revert();
+            // solhint-disable-next-line gas-custom-errors
+            if (result.length == 0) revert("reverted with no reason");
 
+            // solhint-disable-next-line no-inline-assembly
             assembly {
                 revert(add(32, result), mload(result))
             }
@@ -24,11 +26,14 @@ contract Caller {
     // TODO: Callcode
 
     function functionDelegateCall(address to, bytes calldata data) external {
+        // solhint-disable-next-line avoid-low-level-calls
         (bool success, bytes memory result) = to.delegatecall(data);
 
         if (!success) {
-            if (result.length == 0) revert();
+            // solhint-disable-next-line gas-custom-errors
+            if (result.length == 0) revert("reverted with no reason");
 
+            // solhint-disable-next-line no-inline-assembly
             assembly {
                 revert(add(32, result), mload(result))
             }
@@ -39,8 +44,10 @@ contract Caller {
         (bool success, bytes memory result) = to.staticcall(data);
 
         if (!success) {
-            if (result.length == 0) revert();
+            // solhint-disable-next-line gas-custom-errors
+            if (result.length == 0) revert("reverted with no reason");
 
+            // solhint-disable-next-line no-inline-assembly
             assembly {
                 revert(add(32, result), mload(result))
             }
@@ -52,7 +59,7 @@ contract Caller {
 // High level caller
 //
 contract NoopCaller {
-    NoopNoReceiveNoFallback target;
+    NoopNoReceiveNoFallback private target;
 
     constructor(NoopNoReceiveNoFallback _target) {
         target = _target;

tests/e2e-evm/contracts/ABI_DisabledTests.sol

@@ -1,37 +1,38 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.24;
 
-import "./ABI_BasicTests.sol";
+import "./ABI_BasicTests.sol" as ABI_BasicTests;
 
 //
 // Disabled contract that is payable and callable with any calldata (receive + fallback)
 //
-contract NoopDisabledMock is NoopReceivePayableFallback{
+contract NoopDisabledMock is ABI_BasicTests.NoopReceivePayableFallback {
     // solc-ignore-next-line func-mutability
     function noopNonpayable() external {
-      mockRevert();
+        mockRevert();
     }
     function noopPayable() external payable {
-      mockRevert();
+        mockRevert();
     }
     // solc-ignore-next-line func-mutability
     function noopView() external view {
-      mockRevert();
+        mockRevert();
     }
     function noopPure() external pure {
-      mockRevert();
+        mockRevert();
     }
     receive() external payable {
-      mockRevert();
+        mockRevert();
     }
     fallback() external payable {
-      mockRevert();
+        mockRevert();
     }
 
     //
     // Mimic revert + revert reason
     //
     function mockRevert() private pure {
-      revert("call not allowed to disabled contract");
+        // solhint-disable-next-line reason-string, gas-custom-errors
+        revert("call not allowed to disabled contract");
     }
 }